You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@activemq.apache.org by ro...@apache.org on 2022/08/29 15:36:07 UTC
[activemq-artemis] 01/04: remove a couple TODOs not needed
This is an automated email from the ASF dual-hosted git repository.
robbie pushed a commit to branch new-logging
in repository https://gitbox.apache.org/repos/asf/activemq-artemis.git
commit 1c44336657dbbf9a934a491d1d9a580f1ff60dc4
Author: Robbie Gemmell <ro...@apache.org>
AuthorDate: Fri Aug 26 11:40:23 2022 +0100
remove a couple TODOs not needed
---
.../activemq/artemis/core/postoffice/impl/PostOfficeImpl.java | 2 +-
.../org/apache/activemq/artemis/logs/AssertionLoggerHandler.java | 6 ------
2 files changed, 1 insertion(+), 7 deletions(-)
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
index 27167f3e39..3e5ecdf705 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
@@ -1175,7 +1175,7 @@ public class PostOfficeImpl implements PostOffice, NotificationListener, Binding
addressInfo.incrementUnRoutedMessageCount();
}
// this is a debug and not warn because this could be a regular scenario on publish-subscribe queues (or topic subscriptions on JMS)
- logger.debug("Couldn't find any bindings for address={} on message={}", address, message); //TODO: the arg-removal fix made reversed the values position but fixed the names. Could move the names instead to retain position?
+ logger.debug("Couldn't find any bindings for address={} on message={}", address, message);
}
if (server.hasBrokerMessagePlugins()) {
diff --git a/artemis-unit-test-support/src/main/java/org/apache/activemq/artemis/logs/AssertionLoggerHandler.java b/artemis-unit-test-support/src/main/java/org/apache/activemq/artemis/logs/AssertionLoggerHandler.java
index 2c4b4037b7..f78f92bb9a 100644
--- a/artemis-unit-test-support/src/main/java/org/apache/activemq/artemis/logs/AssertionLoggerHandler.java
+++ b/artemis-unit-test-support/src/main/java/org/apache/activemq/artemis/logs/AssertionLoggerHandler.java
@@ -89,12 +89,6 @@ public class AssertionLoggerHandler extends AbstractAppender {
}
}
- @Override
- public void stop() {
- super.stop();
- // TODO Do we need to do anything here? Set capture false and clear?
- }
-
/**
* is there any record matching Level?
*