[jira] [Commented] (CB-4602) getPreferredLanguage platform inconsistencies

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-4602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13963280#comment-13963280 ] 

ASF GitHub Bot commented on CB-4602:
------------------------------------

GitHub user svkirans opened a pull request:

    https://github.com/apache/cordova-plugin-globalization/pull/8

    The  ISO 639-2 code is returned for the default language. Probable fix f...

    The  ISO 639-2 code is returned for the default language. Probable fix for CB-4602.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/svkirans/cordova-plugin-globalization master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-globalization/pull/8.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #8
    
----
commit bdf8fb23797fb2acbb5f91cc017c5e365771ea7d
Author: Kiran <sv...@gmail.com>
Date:   2014-04-08T18:17:53Z

    The  ISO 639-2 code is returned for the default language. Probable fix for CB-4602.

----


> getPreferredLanguage platform inconsistencies
> ---------------------------------------------
>
>                 Key: CB-4602
>                 URL: https://issues.apache.org/jira/browse/CB-4602
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android, Plugin Globalization
>    Affects Versions: 2.6.0, 3.0.0
>         Environment: Android
>            Reporter: Jon Whitlock
>            Assignee: Joe Bowser
>            Priority: Minor
>
> In;
> https://github.com/apache/cordova-docs/blob/master/docs/en/edge/cordova/globalization/globalization.getPreferredLanguage.md
> "Returns the language identifier string to the successCallback with a properties object as a parameter. That object should have a value property with a String value."
> navigator.globalization.getPreferredLanguage(
>    function (language) {alert('language: ' + language.value + '\n');},
>    function () {alert('Error getting language\n');}
> );
> On Android the function doesn't seem to return an identifier as such, it returns *a string describing the language localised to that language*, e.g. "English" for English or "中文" for Japanese. Naturally this is less than ideal for subsequent string operations, furthermore on that page "Windows Phone 8 Quirks - Returns the ISO 639-1 two-letter code for the current language" which is an identifier, and also what I would expect (or an ISO 639-2 code, as per http://www.loc.gov/standards/iso639-2/php/code_list.php)
> Android seems to support 639-2 http://developer.android.com/reference/java/util/Locale.html#getISO3Language()
> I have no idea what it returns on other platforms, but to keep client code consistent I guess it would good if this could be normalised in the API.
> Have tested this on v3.0 and 2.6, is the same.
> As an aside, the locale is not really what I want here, as the user may be in the US but have Japanese as their preferred language.
> Thanks,
> jon
> (first go at using Jira, apols if I got something wrong!)



--
This message was sent by Atlassian JIRA
(v6.2#6252)