You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "maksaska (via GitHub)" <gi...@apache.org> on 2024/10/22 08:45:16 UTC
[PR] IGNITE-23168 Event consumption time metric in CDC consumer [ignite]
maksaska opened a new pull request, #11612:
URL: https://github.com/apache/ignite/pull/11612
Within this commit there are 2 metrics implemented:
* EventsConsumptionTime - Time for which this CDC client processed the WAL segment events, in nanoseconds.
* EventsConsumptionTimeTotal - The total time for which this CDC client processed the WAL segments events, in nanoseconds.
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23168 Event consumption time metric in CDC consumer [ignite]
Posted by "shishkovilja (via GitHub)" <gi...@apache.org>.
shishkovilja commented on code in PR #11612:
URL: https://github.com/apache/ignite/pull/11612#discussion_r1829683730
##########
modules/core/src/test/java/org/apache/ignite/cdc/AbstractCdcTest.java:
##########
@@ -269,6 +261,55 @@ private void checkMetrics(long expCnt, Function<String, Long> longMetric, Functi
assertEquals(expCnt, (long)longMetric.apply(EVTS_CNT));
}
+ /**
+ * @param cdc - {@link CdcMain} instance.
+ */
+ protected void checkWalProcessingMetrics(CdcMain cdc) {
+ DynamicMBean jmxCdcReg = getJmxCdcReg(cdc);
+
+ checkWalProcessingMetrics((Function<String, Long>)jmxVal(jmxCdcReg), (Function<String, long[]>)jmxVal(jmxCdcReg));
+
+ MetricRegistry mreg = getMetricRegistry(cdc);
+
+ checkWalProcessingMetrics(
+ m -> mreg.<LongMetric>findMetric(m).value(),
+ m -> mreg.<HistogramMetricImpl>findMetric(m).value()
+ );
+ }
+
+ /** Checks the metrics for WAL processing. */
+ private void checkWalProcessingMetrics(Function<String, Long> longMetric, Function<String, long[]> longMetricArray) {
+ assertNotNull(longMetric.apply(EVENTS_CONSUMPTION_TIME_TOTAL));
+
+ assertTrue(longMetric.apply(EVENTS_CONSUMPTION_TIME_TOTAL) > 0);
+
+ assertTrue(Arrays.stream(longMetricArray.apply(EVENTS_CONSUMPTION_TIME)).sum() > 0);
+ }
+
+ /** @return MBean for CDC metrics */
+ private DynamicMBean getJmxCdcReg(CdcMain cdc) {
Review Comment:
```suggestion
private DynamicMBean jmxRegistry(CdcMain cdc) {
```
##########
modules/core/src/test/java/org/apache/ignite/cdc/AbstractCdcTest.java:
##########
@@ -269,6 +261,55 @@ private void checkMetrics(long expCnt, Function<String, Long> longMetric, Functi
assertEquals(expCnt, (long)longMetric.apply(EVTS_CNT));
}
+ /**
+ * @param cdc - {@link CdcMain} instance.
+ */
+ protected void checkWalProcessingMetrics(CdcMain cdc) {
+ DynamicMBean jmxCdcReg = getJmxCdcReg(cdc);
+
+ checkWalProcessingMetrics((Function<String, Long>)jmxVal(jmxCdcReg), (Function<String, long[]>)jmxVal(jmxCdcReg));
+
+ MetricRegistry mreg = getMetricRegistry(cdc);
+
+ checkWalProcessingMetrics(
+ m -> mreg.<LongMetric>findMetric(m).value(),
+ m -> mreg.<HistogramMetricImpl>findMetric(m).value()
+ );
+ }
+
+ /** Checks the metrics for WAL processing. */
+ private void checkWalProcessingMetrics(Function<String, Long> longMetric, Function<String, long[]> longMetricArray) {
+ assertNotNull(longMetric.apply(EVENTS_CONSUMPTION_TIME_TOTAL));
+
+ assertTrue(longMetric.apply(EVENTS_CONSUMPTION_TIME_TOTAL) > 0);
+
+ assertTrue(Arrays.stream(longMetricArray.apply(EVENTS_CONSUMPTION_TIME)).sum() > 0);
+ }
+
+ /** @return MBean for CDC metrics */
+ private DynamicMBean getJmxCdcReg(CdcMain cdc) {
+ IgniteConfiguration cfg = getFieldValue(cdc, "igniteCfg");
+
+ return metricRegistry(cdcInstanceName(cfg.getIgniteInstanceName()), null, "cdc");
+ }
+
+ /** @return {@link MetricRegistry} */
+ private MetricRegistry getMetricRegistry(CdcMain cdc) {
Review Comment:
```suggestion
private MetricRegistry registry(CdcMain cdc) {
```
##########
modules/core/src/test/java/org/apache/ignite/cdc/AbstractCdcTest.java:
##########
@@ -269,6 +261,55 @@ private void checkMetrics(long expCnt, Function<String, Long> longMetric, Functi
assertEquals(expCnt, (long)longMetric.apply(EVTS_CNT));
}
+ /**
+ * @param cdc - {@link CdcMain} instance.
+ */
+ protected void checkWalProcessingMetrics(CdcMain cdc) {
+ DynamicMBean jmxCdcReg = getJmxCdcReg(cdc);
+
+ checkWalProcessingMetrics((Function<String, Long>)jmxVal(jmxCdcReg), (Function<String, long[]>)jmxVal(jmxCdcReg));
+
+ MetricRegistry mreg = getMetricRegistry(cdc);
+
+ checkWalProcessingMetrics(
+ m -> mreg.<LongMetric>findMetric(m).value(),
+ m -> mreg.<HistogramMetricImpl>findMetric(m).value()
+ );
+ }
+
+ /** Checks the metrics for WAL processing. */
+ private void checkWalProcessingMetrics(Function<String, Long> longMetric, Function<String, long[]> longMetricArray) {
+ assertNotNull(longMetric.apply(EVENTS_CONSUMPTION_TIME_TOTAL));
+
+ assertTrue(longMetric.apply(EVENTS_CONSUMPTION_TIME_TOTAL) > 0);
+
+ assertTrue(Arrays.stream(longMetricArray.apply(EVENTS_CONSUMPTION_TIME)).sum() > 0);
+ }
+
+ /** @return MBean for CDC metrics */
+ private DynamicMBean getJmxCdcReg(CdcMain cdc) {
+ IgniteConfiguration cfg = getFieldValue(cdc, "igniteCfg");
+
+ return metricRegistry(cdcInstanceName(cfg.getIgniteInstanceName()), null, "cdc");
+ }
+
+ /** @return {@link MetricRegistry} */
+ private MetricRegistry getMetricRegistry(CdcMain cdc) {
+ return getFieldValue(cdc, "mreg");
+ }
+
+ /** */
+ private Function<String, ?> jmxVal(DynamicMBean jmxCdcReg) {
Review Comment:
```suggestion
private Function<String, ?> jmxValue(DynamicMBean jmxCdcReg) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23168 Event consumption time metric in CDC consumer [ignite]
Posted by "timoninmaxim (via GitHub)" <gi...@apache.org>.
timoninmaxim commented on code in PR #11612:
URL: https://github.com/apache/ignite/pull/11612#discussion_r1856941055
##########
modules/core/src/test/java/org/apache/ignite/cdc/CdcSelfTest.java:
##########
@@ -291,6 +294,15 @@ private void readAll(UserCdcConsumer cnsmr, boolean offsetCommit) throws Excepti
checkMetrics(cdcMain, offsetCommit ? KEYS_CNT : ((KEYS_CNT + 3) * 2 + KEYS_CNT));
+ // Metric check awaits the CDC consumer to finish
Review Comment:
Put a dot in the end of the comment.
##########
modules/core/src/test/java/org/apache/ignite/cdc/CdcSelfTest.java:
##########
@@ -291,6 +294,15 @@ private void readAll(UserCdcConsumer cnsmr, boolean offsetCommit) throws Excepti
checkMetrics(cdcMain, offsetCommit ? KEYS_CNT : ((KEYS_CNT + 3) * 2 + KEYS_CNT));
+ // Metric check awaits the CDC consumer to finish
+ MetricRegistry mreg = getFieldValue(cdcMain, "mreg");
Review Comment:
inline it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23168 Event consumption time metric in CDC consumer [ignite]
Posted by "timoninmaxim (via GitHub)" <gi...@apache.org>.
timoninmaxim merged PR #11612:
URL: https://github.com/apache/ignite/pull/11612
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23168 Event consumption time metric in CDC consumer [ignite]
Posted by "timoninmaxim (via GitHub)" <gi...@apache.org>.
timoninmaxim commented on code in PR #11612:
URL: https://github.com/apache/ignite/pull/11612#discussion_r1863164755
##########
modules/core/src/main/java/org/apache/ignite/internal/cdc/CdcMain.java:
##########
@@ -575,13 +585,20 @@ private boolean consumeSegment(Path segment) {
curSegmentIdx.value(segmentIdx);
+ long start = U.currentTimeMillis();
+
if (cdcModeState == CdcMode.IGNITE_NODE_ACTIVE) {
- if (consumeSegmentPassively(builder))
+ if (consumeSegmentPassively(builder)) {
+ walProcessingTime.value(U.currentTimeMillis() - start);
+
return true;
+ }
}
else
consumeSegmentActively(builder);
+ walProcessingTime.value(U.currentTimeMillis() - start);
Review Comment:
code duplication
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23168 Event consumption time metric in CDC consumer [ignite]
Posted by "maksaska (via GitHub)" <gi...@apache.org>.
maksaska commented on code in PR #11612:
URL: https://github.com/apache/ignite/pull/11612#discussion_r1825743887
##########
docs/_docs/persistence/change-data-capture.adoc:
##########
@@ -125,6 +125,8 @@ The following metrics are provided by the application (additional metrics can be
| BinaryMetaDir | Binary meta-directory the application reads data from.
| MarshallerDir | Marshaller directory the application reads data from.
| CdcDir | The CDC directory the application reads data from.
+| EventsConsumptionTime | Time for which this CDC client processed the WAL segment events, in nanoseconds.
Review Comment:
Agree
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23168 Event consumption time metric in CDC consumer [ignite]
Posted by "timoninmaxim (via GitHub)" <gi...@apache.org>.
timoninmaxim commented on code in PR #11612:
URL: https://github.com/apache/ignite/pull/11612#discussion_r1863105503
##########
docs/_docs/persistence/change-data-capture.adoc:
##########
@@ -125,6 +125,7 @@ The following metrics are provided by the application (additional metrics can be
| BinaryMetaDir | Binary meta-directory the application reads data from.
| MarshallerDir | Marshaller directory the application reads data from.
| CdcDir | The CDC directory the application reads data from.
+| WalProcessingTime | Time of WAL segment processing, in milliseconds.
Review Comment:
SegmentConsumingTime
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23168 Event consumption time metric in CDC consumer [ignite]
Posted by "maksaska (via GitHub)" <gi...@apache.org>.
maksaska commented on code in PR #11612:
URL: https://github.com/apache/ignite/pull/11612#discussion_r1825743477
##########
docs/_docs/persistence/change-data-capture.adoc:
##########
@@ -125,6 +125,8 @@ The following metrics are provided by the application (additional metrics can be
| BinaryMetaDir | Binary meta-directory the application reads data from.
| MarshallerDir | Marshaller directory the application reads data from.
| CdcDir | The CDC directory the application reads data from.
+| EventsConsumptionTime | Time for which this CDC client processed the WAL segment events, in nanoseconds.
+| EventsConsumptionTimeTotal | The total time for which this CDC client processed the WAL segments events, in nanoseconds.
Review Comment:
Agree
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23168 Event consumption time metric in CDC consumer [ignite]
Posted by "timoninmaxim (via GitHub)" <gi...@apache.org>.
timoninmaxim commented on code in PR #11612:
URL: https://github.com/apache/ignite/pull/11612#discussion_r1881756327
##########
modules/core/src/main/java/org/apache/ignite/internal/cdc/CdcMain.java:
##########
@@ -212,6 +215,9 @@ public class CdcMain implements Runnable {
*/
private HistogramMetricImpl evtCaptureTime;
+ /** Metric represents time between creating {@link WALIterator} and processing it, in milliseconds. */
Review Comment:
prossing -> finish consuming it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23168 Event consumption time metric in CDC consumer [ignite]
Posted by "timoninmaxim (via GitHub)" <gi...@apache.org>.
timoninmaxim commented on code in PR #11612:
URL: https://github.com/apache/ignite/pull/11612#discussion_r1852197647
##########
modules/core/src/main/java/org/apache/ignite/internal/cdc/CdcMain.java:
##########
@@ -612,6 +629,10 @@ private void consumeSegmentActively(IgniteWalIteratorFactory.IteratorParametersB
if (interrupted)
throw new IgniteException("Change Data Capture Application interrupted");
+
+ long duration = U.currentTimeMillis() - start;
Review Comment:
can be inlined
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23168 Event consumption time metric in CDC consumer [ignite]
Posted by "maksaska (via GitHub)" <gi...@apache.org>.
maksaska commented on code in PR #11612:
URL: https://github.com/apache/ignite/pull/11612#discussion_r1874506649
##########
docs/_docs/persistence/change-data-capture.adoc:
##########
@@ -125,6 +125,7 @@ The following metrics are provided by the application (additional metrics can be
| BinaryMetaDir | Binary meta-directory the application reads data from.
| MarshallerDir | Marshaller directory the application reads data from.
| CdcDir | The CDC directory the application reads data from.
+| WalProcessingTime | Time of WAL segment processing, in milliseconds.
Review Comment:
Done!
##########
modules/core/src/main/java/org/apache/ignite/internal/cdc/CdcMain.java:
##########
@@ -575,13 +585,20 @@ private boolean consumeSegment(Path segment) {
curSegmentIdx.value(segmentIdx);
+ long start = U.currentTimeMillis();
+
if (cdcModeState == CdcMode.IGNITE_NODE_ACTIVE) {
- if (consumeSegmentPassively(builder))
+ if (consumeSegmentPassively(builder)) {
+ walProcessingTime.value(U.currentTimeMillis() - start);
+
return true;
+ }
}
else
consumeSegmentActively(builder);
+ walProcessingTime.value(U.currentTimeMillis() - start);
Review Comment:
Removed code duplication
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23168 Event consumption time metric in CDC consumer [ignite]
Posted by "maksaska (via GitHub)" <gi...@apache.org>.
maksaska commented on code in PR #11612:
URL: https://github.com/apache/ignite/pull/11612#discussion_r1825743670
##########
modules/core/src/main/java/org/apache/ignite/internal/cdc/CdcMain.java:
##########
@@ -204,6 +229,12 @@ public class CdcMain implements Runnable {
/** Time of last segment consumption. */
private AtomicLongMetric lastSegmentConsumptionTs;
+ /** Metric shows duration of the last WAL segment events consumption. */
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23168 Event consumption time metric in CDC consumer [ignite]
Posted by "maksaska (via GitHub)" <gi...@apache.org>.
maksaska commented on code in PR #11612:
URL: https://github.com/apache/ignite/pull/11612#discussion_r1831130233
##########
modules/core/src/test/java/org/apache/ignite/cdc/AbstractCdcTest.java:
##########
@@ -269,6 +261,55 @@ private void checkMetrics(long expCnt, Function<String, Long> longMetric, Functi
assertEquals(expCnt, (long)longMetric.apply(EVTS_CNT));
}
+ /**
+ * @param cdc - {@link CdcMain} instance.
+ */
+ protected void checkWalProcessingMetrics(CdcMain cdc) {
+ DynamicMBean jmxCdcReg = getJmxCdcReg(cdc);
+
+ checkWalProcessingMetrics((Function<String, Long>)jmxVal(jmxCdcReg), (Function<String, long[]>)jmxVal(jmxCdcReg));
+
+ MetricRegistry mreg = getMetricRegistry(cdc);
+
+ checkWalProcessingMetrics(
+ m -> mreg.<LongMetric>findMetric(m).value(),
+ m -> mreg.<HistogramMetricImpl>findMetric(m).value()
+ );
+ }
+
+ /** Checks the metrics for WAL processing. */
+ private void checkWalProcessingMetrics(Function<String, Long> longMetric, Function<String, long[]> longMetricArray) {
+ assertNotNull(longMetric.apply(EVENTS_CONSUMPTION_TIME_TOTAL));
+
+ assertTrue(longMetric.apply(EVENTS_CONSUMPTION_TIME_TOTAL) > 0);
+
+ assertTrue(Arrays.stream(longMetricArray.apply(EVENTS_CONSUMPTION_TIME)).sum() > 0);
+ }
+
+ /** @return MBean for CDC metrics */
+ private DynamicMBean getJmxCdcReg(CdcMain cdc) {
+ IgniteConfiguration cfg = getFieldValue(cdc, "igniteCfg");
+
+ return metricRegistry(cdcInstanceName(cfg.getIgniteInstanceName()), null, "cdc");
+ }
+
+ /** @return {@link MetricRegistry} */
+ private MetricRegistry getMetricRegistry(CdcMain cdc) {
+ return getFieldValue(cdc, "mreg");
+ }
+
+ /** */
+ private Function<String, ?> jmxVal(DynamicMBean jmxCdcReg) {
Review Comment:
Renamed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23168 Event consumption time metric in CDC consumer [ignite]
Posted by "maksaska (via GitHub)" <gi...@apache.org>.
maksaska commented on code in PR #11612:
URL: https://github.com/apache/ignite/pull/11612#discussion_r1825744093
##########
modules/core/src/main/java/org/apache/ignite/internal/cdc/CdcMain.java:
##########
@@ -183,6 +185,29 @@ public class CdcMain implements Runnable {
private static final IgniteBiPredicate<WALRecord.RecordType, WALPointer> ACTIVE_RECS =
(type, ptr) -> type == DATA_RECORD_V2 || type == CDC_DATA_RECORD;
+ /** Histogram buckets for duration wal processing in nanoseconds. */
+ public static final long[] HISTOGRAM_BUCKETS = new long[] {
+ NANOSECONDS.convert(1, MILLISECONDS),
+ NANOSECONDS.convert(10, MILLISECONDS),
+ NANOSECONDS.convert(100, MILLISECONDS),
+ NANOSECONDS.convert(250, MILLISECONDS),
+ NANOSECONDS.convert(1000, MILLISECONDS)
+ };
+
+ /** */
+ public static final String EVENTS_CONSUMPTION_TIME = "EventsConsumptionTime";
+
+ /** */
+ public static final String EVENTS_CONSUMPTION_TIME_DESC =
+ "Time for which this CDC client processed the WAL segment events, in nanoseconds.";
+
+ /** */
+ public static final String EVENTS_CONSUMPTION_TIME_TOTAL = "EventsConsumptionTimeTotal";
+
+ /** */
+ public static final String EVENTS_CONSUMPTION_TIME_TOTAL_DESC =
Review Comment:
Fixed it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23168 Event consumption time metric in CDC consumer [ignite]
Posted by "maksaska (via GitHub)" <gi...@apache.org>.
maksaska commented on code in PR #11612:
URL: https://github.com/apache/ignite/pull/11612#discussion_r1825749155
##########
modules/core/src/main/java/org/apache/ignite/internal/cdc/CdcMain.java:
##########
@@ -183,6 +185,29 @@ public class CdcMain implements Runnable {
private static final IgniteBiPredicate<WALRecord.RecordType, WALPointer> ACTIVE_RECS =
(type, ptr) -> type == DATA_RECORD_V2 || type == CDC_DATA_RECORD;
+ /** Histogram buckets for duration wal processing in nanoseconds. */
+ public static final long[] HISTOGRAM_BUCKETS = new long[] {
+ NANOSECONDS.convert(1, MILLISECONDS),
+ NANOSECONDS.convert(10, MILLISECONDS),
+ NANOSECONDS.convert(100, MILLISECONDS),
+ NANOSECONDS.convert(250, MILLISECONDS),
+ NANOSECONDS.convert(1000, MILLISECONDS)
+ };
+
+ /** */
+ public static final String EVENTS_CONSUMPTION_TIME = "EventsConsumptionTime";
+
+ /** */
+ public static final String EVENTS_CONSUMPTION_TIME_DESC =
Review Comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23168 Event consumption time metric in CDC consumer [ignite]
Posted by "maksaska (via GitHub)" <gi...@apache.org>.
maksaska commented on code in PR #11612:
URL: https://github.com/apache/ignite/pull/11612#discussion_r1852231955
##########
modules/core/src/test/java/org/apache/ignite/cdc/AbstractCdcTest.java:
##########
@@ -222,37 +224,32 @@ protected GridAbsPredicate sizePredicate(
/** */
protected void checkMetrics(CdcMain cdc, int expCnt) throws Exception {
- IgniteConfiguration cfg = getFieldValue(cdc, "igniteCfg");
Review Comment:
It's redundant code, that I left by mistake from previous commits. Fixed it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23168 Event consumption time metric in CDC consumer [ignite]
Posted by "timoninmaxim (via GitHub)" <gi...@apache.org>.
timoninmaxim commented on code in PR #11612:
URL: https://github.com/apache/ignite/pull/11612#discussion_r1856941787
##########
modules/core/src/test/java/org/apache/ignite/cdc/CdcSelfTest.java:
##########
@@ -291,6 +294,15 @@ private void readAll(UserCdcConsumer cnsmr, boolean offsetCommit) throws Excepti
checkMetrics(cdcMain, offsetCommit ? KEYS_CNT : ((KEYS_CNT + 3) * 2 + KEYS_CNT));
+ // Metric check awaits the CDC consumer to finish
+ MetricRegistry mreg = getFieldValue(cdcMain, "mreg");
+
+ long[] evtCaptureTime = mreg.<HistogramMetric>findMetric(EVENTS_CONSUMPTION_TIME).value();
+
+ assertFalse(F.isEmpty(evtCaptureTime));
+
Review Comment:
remove blank line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23168 Event consumption time metric in CDC consumer [ignite]
Posted by "shishkovilja (via GitHub)" <gi...@apache.org>.
shishkovilja commented on code in PR #11612:
URL: https://github.com/apache/ignite/pull/11612#discussion_r1823183000
##########
docs/_docs/persistence/change-data-capture.adoc:
##########
@@ -125,6 +125,8 @@ The following metrics are provided by the application (additional metrics can be
| BinaryMetaDir | Binary meta-directory the application reads data from.
| MarshallerDir | Marshaller directory the application reads data from.
| CdcDir | The CDC directory the application reads data from.
+| EventsConsumptionTime | Time for which this CDC client processed the WAL segment events, in nanoseconds.
Review Comment:
```suggestion
| EventsConsumptionTime | Time of WAL segment events processing by a CDC consumer, in nanoseconds.
```
##########
modules/core/src/main/java/org/apache/ignite/internal/cdc/CdcMain.java:
##########
@@ -616,6 +652,18 @@ private void consumeSegmentActively(IgniteWalIteratorFactory.IteratorParametersB
catch (IgniteCheckedException | IOException e) {
throw new IgniteException(e);
}
+ finally {
+ updateWalProcessingMetrics(System.nanoTime() - start);
+ }
+ }
+
+ /**
+ * Updates consumer event coonsumption metrics.
+ * @param duration - Operation durtion.
+ */
+ private void updateWalProcessingMetrics(long duration) {
Review Comment:
This method consisting of two lines is used only once, why should we add it?
##########
modules/core/src/main/java/org/apache/ignite/internal/cdc/CdcMain.java:
##########
@@ -183,6 +185,29 @@ public class CdcMain implements Runnable {
private static final IgniteBiPredicate<WALRecord.RecordType, WALPointer> ACTIVE_RECS =
(type, ptr) -> type == DATA_RECORD_V2 || type == CDC_DATA_RECORD;
+ /** Histogram buckets for duration wal processing in nanoseconds. */
+ public static final long[] HISTOGRAM_BUCKETS = new long[] {
+ NANOSECONDS.convert(1, MILLISECONDS),
+ NANOSECONDS.convert(10, MILLISECONDS),
+ NANOSECONDS.convert(100, MILLISECONDS),
+ NANOSECONDS.convert(250, MILLISECONDS),
+ NANOSECONDS.convert(1000, MILLISECONDS)
+ };
+
+ /** */
+ public static final String EVENTS_CONSUMPTION_TIME = "EventsConsumptionTime";
+
+ /** */
+ public static final String EVENTS_CONSUMPTION_TIME_DESC =
+ "Time for which this CDC client processed the WAL segment events, in nanoseconds.";
+
+ /** */
+ public static final String EVENTS_CONSUMPTION_TIME_TOTAL = "EventsConsumptionTimeTotal";
+
+ /** */
+ public static final String EVENTS_CONSUMPTION_TIME_TOTAL_DESC =
Review Comment:
Fix it in the same way as the documentation.
##########
modules/core/src/main/java/org/apache/ignite/internal/cdc/CdcMain.java:
##########
@@ -204,6 +229,12 @@ public class CdcMain implements Runnable {
/** Time of last segment consumption. */
private AtomicLongMetric lastSegmentConsumptionTs;
+ /** Metric shows duration of the last WAL segment events consumption. */
+ private HistogramMetricImpl eventsConsumptionTime;
+
+ /** Metric shows the total duration of WAL segment events consumption. */
Review Comment:
Fix it in the same way as the documentation.
##########
modules/core/src/main/java/org/apache/ignite/internal/cdc/CdcMain.java:
##########
@@ -183,6 +185,29 @@ public class CdcMain implements Runnable {
private static final IgniteBiPredicate<WALRecord.RecordType, WALPointer> ACTIVE_RECS =
(type, ptr) -> type == DATA_RECORD_V2 || type == CDC_DATA_RECORD;
+ /** Histogram buckets for duration wal processing in nanoseconds. */
+ public static final long[] HISTOGRAM_BUCKETS = new long[] {
+ NANOSECONDS.convert(1, MILLISECONDS),
+ NANOSECONDS.convert(10, MILLISECONDS),
+ NANOSECONDS.convert(100, MILLISECONDS),
+ NANOSECONDS.convert(250, MILLISECONDS),
+ NANOSECONDS.convert(1000, MILLISECONDS)
+ };
+
+ /** */
+ public static final String EVENTS_CONSUMPTION_TIME = "EventsConsumptionTime";
+
+ /** */
+ public static final String EVENTS_CONSUMPTION_TIME_DESC =
Review Comment:
Fix it in the same way as the documentation.
##########
docs/_docs/persistence/change-data-capture.adoc:
##########
@@ -125,6 +125,8 @@ The following metrics are provided by the application (additional metrics can be
| BinaryMetaDir | Binary meta-directory the application reads data from.
| MarshallerDir | Marshaller directory the application reads data from.
| CdcDir | The CDC directory the application reads data from.
+| EventsConsumptionTime | Time for which this CDC client processed the WAL segment events, in nanoseconds.
+| EventsConsumptionTimeTotal | The total time for which this CDC client processed the WAL segments events, in nanoseconds.
Review Comment:
```suggestion
| EventsConsumptionTimeTotal | Total time of events processing by a CDC consumer, in nanoseconds.
```
##########
modules/core/src/main/java/org/apache/ignite/internal/cdc/CdcMain.java:
##########
@@ -204,6 +229,12 @@ public class CdcMain implements Runnable {
/** Time of last segment consumption. */
private AtomicLongMetric lastSegmentConsumptionTs;
+ /** Metric shows duration of the last WAL segment events consumption. */
Review Comment:
Fix it in the same way as the documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23168 Event consumption time metric in CDC consumer [ignite]
Posted by "maksaska (via GitHub)" <gi...@apache.org>.
maksaska commented on code in PR #11612:
URL: https://github.com/apache/ignite/pull/11612#discussion_r1881818289
##########
modules/core/src/main/java/org/apache/ignite/internal/cdc/CdcMain.java:
##########
@@ -212,6 +215,9 @@ public class CdcMain implements Runnable {
*/
private HistogramMetricImpl evtCaptureTime;
+ /** Metric represents time between creating {@link WALIterator} and processing it, in milliseconds. */
Review Comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23168 Event consumption time metric in CDC consumer [ignite]
Posted by "maksaska (via GitHub)" <gi...@apache.org>.
maksaska commented on code in PR #11612:
URL: https://github.com/apache/ignite/pull/11612#discussion_r1831129861
##########
modules/core/src/test/java/org/apache/ignite/cdc/AbstractCdcTest.java:
##########
@@ -269,6 +261,55 @@ private void checkMetrics(long expCnt, Function<String, Long> longMetric, Functi
assertEquals(expCnt, (long)longMetric.apply(EVTS_CNT));
}
+ /**
+ * @param cdc - {@link CdcMain} instance.
+ */
+ protected void checkWalProcessingMetrics(CdcMain cdc) {
+ DynamicMBean jmxCdcReg = getJmxCdcReg(cdc);
+
+ checkWalProcessingMetrics((Function<String, Long>)jmxVal(jmxCdcReg), (Function<String, long[]>)jmxVal(jmxCdcReg));
+
+ MetricRegistry mreg = getMetricRegistry(cdc);
+
+ checkWalProcessingMetrics(
+ m -> mreg.<LongMetric>findMetric(m).value(),
+ m -> mreg.<HistogramMetricImpl>findMetric(m).value()
+ );
+ }
+
+ /** Checks the metrics for WAL processing. */
+ private void checkWalProcessingMetrics(Function<String, Long> longMetric, Function<String, long[]> longMetricArray) {
+ assertNotNull(longMetric.apply(EVENTS_CONSUMPTION_TIME_TOTAL));
+
+ assertTrue(longMetric.apply(EVENTS_CONSUMPTION_TIME_TOTAL) > 0);
+
+ assertTrue(Arrays.stream(longMetricArray.apply(EVENTS_CONSUMPTION_TIME)).sum() > 0);
+ }
+
+ /** @return MBean for CDC metrics */
+ private DynamicMBean getJmxCdcReg(CdcMain cdc) {
Review Comment:
Done!
##########
modules/core/src/test/java/org/apache/ignite/cdc/AbstractCdcTest.java:
##########
@@ -269,6 +261,55 @@ private void checkMetrics(long expCnt, Function<String, Long> longMetric, Functi
assertEquals(expCnt, (long)longMetric.apply(EVTS_CNT));
}
+ /**
+ * @param cdc - {@link CdcMain} instance.
+ */
+ protected void checkWalProcessingMetrics(CdcMain cdc) {
+ DynamicMBean jmxCdcReg = getJmxCdcReg(cdc);
+
+ checkWalProcessingMetrics((Function<String, Long>)jmxVal(jmxCdcReg), (Function<String, long[]>)jmxVal(jmxCdcReg));
+
+ MetricRegistry mreg = getMetricRegistry(cdc);
+
+ checkWalProcessingMetrics(
+ m -> mreg.<LongMetric>findMetric(m).value(),
+ m -> mreg.<HistogramMetricImpl>findMetric(m).value()
+ );
+ }
+
+ /** Checks the metrics for WAL processing. */
+ private void checkWalProcessingMetrics(Function<String, Long> longMetric, Function<String, long[]> longMetricArray) {
+ assertNotNull(longMetric.apply(EVENTS_CONSUMPTION_TIME_TOTAL));
+
+ assertTrue(longMetric.apply(EVENTS_CONSUMPTION_TIME_TOTAL) > 0);
+
+ assertTrue(Arrays.stream(longMetricArray.apply(EVENTS_CONSUMPTION_TIME)).sum() > 0);
+ }
+
+ /** @return MBean for CDC metrics */
+ private DynamicMBean getJmxCdcReg(CdcMain cdc) {
+ IgniteConfiguration cfg = getFieldValue(cdc, "igniteCfg");
+
+ return metricRegistry(cdcInstanceName(cfg.getIgniteInstanceName()), null, "cdc");
+ }
+
+ /** @return {@link MetricRegistry} */
+ private MetricRegistry getMetricRegistry(CdcMain cdc) {
Review Comment:
Fixed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23168 Event consumption time metric in CDC consumer [ignite]
Posted by "maksaska (via GitHub)" <gi...@apache.org>.
maksaska commented on code in PR #11612:
URL: https://github.com/apache/ignite/pull/11612#discussion_r1852230568
##########
modules/core/src/main/java/org/apache/ignite/internal/cdc/CdcMain.java:
##########
@@ -612,6 +629,10 @@ private void consumeSegmentActively(IgniteWalIteratorFactory.IteratorParametersB
if (interrupted)
throw new IgniteException("Change Data Capture Application interrupted");
+
+ long duration = U.currentTimeMillis() - start;
Review Comment:
Agree. I fixed it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23168 Event consumption time metric in CDC consumer [ignite]
Posted by "maksaska (via GitHub)" <gi...@apache.org>.
maksaska commented on PR #11612:
URL: https://github.com/apache/ignite/pull/11612#issuecomment-2500874260
> 1. Metric name is a little bit misleading
> 2. Metric isn't updated for passive mode
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23168 Event consumption time metric in CDC consumer [ignite]
Posted by "maksaska (via GitHub)" <gi...@apache.org>.
maksaska commented on code in PR #11612:
URL: https://github.com/apache/ignite/pull/11612#discussion_r1856971434
##########
modules/core/src/test/java/org/apache/ignite/cdc/CdcSelfTest.java:
##########
@@ -291,6 +294,15 @@ private void readAll(UserCdcConsumer cnsmr, boolean offsetCommit) throws Excepti
checkMetrics(cdcMain, offsetCommit ? KEYS_CNT : ((KEYS_CNT + 3) * 2 + KEYS_CNT));
+ // Metric check awaits the CDC consumer to finish
+ MetricRegistry mreg = getFieldValue(cdcMain, "mreg");
Review Comment:
Done!
##########
modules/core/src/test/java/org/apache/ignite/cdc/CdcSelfTest.java:
##########
@@ -291,6 +294,15 @@ private void readAll(UserCdcConsumer cnsmr, boolean offsetCommit) throws Excepti
checkMetrics(cdcMain, offsetCommit ? KEYS_CNT : ((KEYS_CNT + 3) * 2 + KEYS_CNT));
+ // Metric check awaits the CDC consumer to finish
+ MetricRegistry mreg = getFieldValue(cdcMain, "mreg");
+
+ long[] evtCaptureTime = mreg.<HistogramMetric>findMetric(EVENTS_CONSUMPTION_TIME).value();
+
+ assertFalse(F.isEmpty(evtCaptureTime));
+
Review Comment:
Done!
##########
modules/core/src/test/java/org/apache/ignite/cdc/CdcSelfTest.java:
##########
@@ -291,6 +294,15 @@ private void readAll(UserCdcConsumer cnsmr, boolean offsetCommit) throws Excepti
checkMetrics(cdcMain, offsetCommit ? KEYS_CNT : ((KEYS_CNT + 3) * 2 + KEYS_CNT));
+ // Metric check awaits the CDC consumer to finish
Review Comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23168 Event consumption time metric in CDC consumer [ignite]
Posted by "maksaska (via GitHub)" <gi...@apache.org>.
maksaska commented on code in PR #11612:
URL: https://github.com/apache/ignite/pull/11612#discussion_r1826582236
##########
modules/core/src/main/java/org/apache/ignite/internal/cdc/CdcMain.java:
##########
@@ -616,6 +652,18 @@ private void consumeSegmentActively(IgniteWalIteratorFactory.IteratorParametersB
catch (IgniteCheckedException | IOException e) {
throw new IgniteException(e);
}
+ finally {
+ updateWalProcessingMetrics(System.nanoTime() - start);
+ }
+ }
+
+ /**
+ * Updates consumer event coonsumption metrics.
+ * @param duration - Operation durtion.
+ */
+ private void updateWalProcessingMetrics(long duration) {
Review Comment:
Removed the method in exchange for local variable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23168 Event consumption time metric in CDC consumer [ignite]
Posted by "maksaska (via GitHub)" <gi...@apache.org>.
maksaska commented on code in PR #11612:
URL: https://github.com/apache/ignite/pull/11612#discussion_r1825744264
##########
modules/core/src/main/java/org/apache/ignite/internal/cdc/CdcMain.java:
##########
@@ -204,6 +229,12 @@ public class CdcMain implements Runnable {
/** Time of last segment consumption. */
private AtomicLongMetric lastSegmentConsumptionTs;
+ /** Metric shows duration of the last WAL segment events consumption. */
+ private HistogramMetricImpl eventsConsumptionTime;
+
+ /** Metric shows the total duration of WAL segment events consumption. */
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23168 Event consumption time metric in CDC consumer [ignite]
Posted by "maksaska (via GitHub)" <gi...@apache.org>.
maksaska commented on code in PR #11612:
URL: https://github.com/apache/ignite/pull/11612#discussion_r1825746883
##########
modules/core/src/main/java/org/apache/ignite/internal/cdc/CdcMain.java:
##########
@@ -616,6 +652,18 @@ private void consumeSegmentActively(IgniteWalIteratorFactory.IteratorParametersB
catch (IgniteCheckedException | IOException e) {
throw new IgniteException(e);
}
+ finally {
+ updateWalProcessingMetrics(System.nanoTime() - start);
+ }
+ }
+
+ /**
+ * Updates consumer event coonsumption metrics.
+ * @param duration - Operation durtion.
+ */
+ private void updateWalProcessingMetrics(long duration) {
Review Comment:
I added it for consistency between `eventsConsumptionTime` and `eventsConsumptionTimeTotal`. By calling this method we fix the duration as a method variable, and assign the same value to both metrics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23168 Event consumption time metric in CDC consumer [ignite]
Posted by "timoninmaxim (via GitHub)" <gi...@apache.org>.
timoninmaxim commented on code in PR #11612:
URL: https://github.com/apache/ignite/pull/11612#discussion_r1856940184
##########
modules/core/src/main/java/org/apache/ignite/internal/cdc/CdcMain.java:
##########
@@ -203,6 +213,9 @@ public class CdcMain implements Runnable {
/** Time of last segment consumption. */
private AtomicLongMetric lastSegmentConsumptionTs;
+ /** Time of WAL segment events processing by a CDC consumer, in milliseconds. */
+ private HistogramMetricImpl eventsConsumptionTime;
Review Comment:
events -> evt
Move the declaration closer to `evtCaptureTime` and describe in javadocs the time range (see how `evtCaptureTime` javadoc is written). Do the same for metric description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23168 Event consumption time metric in CDC consumer [ignite]
Posted by "maksaska (via GitHub)" <gi...@apache.org>.
maksaska commented on code in PR #11612:
URL: https://github.com/apache/ignite/pull/11612#discussion_r1856971188
##########
modules/core/src/main/java/org/apache/ignite/internal/cdc/CdcMain.java:
##########
@@ -203,6 +213,9 @@ public class CdcMain implements Runnable {
/** Time of last segment consumption. */
private AtomicLongMetric lastSegmentConsumptionTs;
+ /** Time of WAL segment events processing by a CDC consumer, in milliseconds. */
+ private HistogramMetricImpl eventsConsumptionTime;
Review Comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23168 Event consumption time metric in CDC consumer [ignite]
Posted by "timoninmaxim (via GitHub)" <gi...@apache.org>.
timoninmaxim commented on code in PR #11612:
URL: https://github.com/apache/ignite/pull/11612#discussion_r1852210686
##########
modules/core/src/test/java/org/apache/ignite/cdc/AbstractCdcTest.java:
##########
@@ -222,37 +224,32 @@ protected GridAbsPredicate sizePredicate(
/** */
protected void checkMetrics(CdcMain cdc, int expCnt) throws Exception {
- IgniteConfiguration cfg = getFieldValue(cdc, "igniteCfg");
Review Comment:
Why do you need this changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org