You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by as...@apache.org on 2023/12/19 22:42:43 UTC

(impala) 01/02: IMPALA-11921: Give more time to test_large_sql in slow builds

This is an automated email from the ASF dual-hosted git repository.

asherman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit 8c3cb56f64cff688dadcf93fe5d5bd93f21b6206
Author: Csaba Ringhofer <cs...@cloudera.com>
AuthorDate: Tue Dec 19 15:40:09 2023 +0100

    IMPALA-11921: Give more time to test_large_sql in slow builds
    
    The test was flaky on ASAN builds, hopefully giving more
    time will solve this.
    
    Change-Id: Id1177bee2a0ad2a0d02f8923369645af02063be8
    Reviewed-on: http://gerrit.cloudera.org:8080/20817
    Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 tests/shell/test_shell_commandline.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/shell/test_shell_commandline.py b/tests/shell/test_shell_commandline.py
index 380441fd7..32ed405da 100644
--- a/tests/shell/test_shell_commandline.py
+++ b/tests/shell/test_shell_commandline.py
@@ -1057,7 +1057,9 @@ class TestImpalaShell(ImpalaTestSuite):
       assert "Could not resolve table reference: 'non_existence_large_table'" \
           in result.stderr
       end_time = time()
-      time_limit_s = 20
+      # Use higher timeout in ASAN/UBSAN to avoid flakiness (IMPALA-11921).
+      build_runs_slowly = ImpalaTestClusterProperties.get_instance().runs_slowly()
+      time_limit_s = 60 if build_runs_slowly else 20
       actual_time_s = end_time - start_time
       assert actual_time_s <= time_limit_s, (
           "It took {0} seconds to execute the query. Time limit is {1} seconds.".format(