[GitHub] [maven-dependency-analyzer] reckart commented on a diff in pull request #82: [MDEP-757] bug with "non-test scoped test only dependencies found"

["reckart (via GitHub)" <gi...@apache.org>]

reckart commented on code in PR #82:
URL: https://github.com/apache/maven-dependency-analyzer/pull/82#discussion_r1140230145


##########
src/main/java/org/apache/maven/shared/dependency/analyzer/asm/ConstantPoolParser.java:
##########
@@ -168,20 +174,46 @@ static Set<String> parseConstantPoolClassReferences( ByteBuffer buf )
                     break;
             }
         }
+        
         Set<String> result = new HashSet<>();
+        
         for ( Integer aClass : classes )
         {
-            String className = stringConstants.get( aClass );
-
-            // filter out things from unnamed package, probably a false-positive
-            if ( isImportableClass( className ) )
+            addClassToResult( result, stringConstants.get( aClass ) );
+        }
+        
+        for ( Integer aType : types )

Review Comment:
   I assume you mean the loop variable name. I used `aType` because the other loop over the classes uses `aClass`. Wouldn't have been my choice either.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org