You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2021/11/16 11:05:05 UTC

[GitHub] [systemds] ywcb00 edited a comment on pull request #1446: [SYSTEMDS-3206] Federated Execution w/ Misaligned Matrices

ywcb00 edited a comment on pull request #1446:
URL: https://github.com/apache/systemds/pull/1446#issuecomment-970159882


   When I extended the tests with misaligned matrices (FederatedMisAlignedTest), I discovered two more issues with the _BinaryMatrixMatrixFEDInstruction_ and the _AppendFEDInstruction_.
   The BinaryMatrixMatrixFEDInstruction was throwing an Exception when called with two federated matrices which are not aligned. I changed it to not throwing an exception and pulling one of the federated matrices to the driver where we can then handle it like a instruction with one federated matrix.
   I've added support for the case of having two aligned federated matrices to the AppendFEDInstruction.
   
   I think this PR is now ready for review :rocket: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org