You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/08/18 00:31:20 UTC
[GitHub] [kafka] cmccabe opened a new pull request #9194: KAFKA-10384: Separate converters from generated messages
cmccabe opened a new pull request #9194:
URL: https://github.com/apache/kafka/pull/9194
For the generated message code, put the JSON conversion functionality
in a separate JsonConverter class.
Make MessageDataGenerator simply another generator class, alongside the
new JsonConverterGenerator class. Move some of the utility functions
from MessageDataGenerator into FieldSpec and other places, so that they
can be used by other generator classes.
Use argparse4j to support a better command-line for the generator.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe commented on pull request #9194: KAFKA-10384: Separate converters from generated messages
Posted by GitBox <gi...@apache.org>.
cmccabe commented on pull request #9194:
URL: https://github.com/apache/kafka/pull/9194#issuecomment-675714307
JDK8 test failure looks like a Jenkins issue.
```
13:29:01 Fetching upstream changes from git://github.com/apache/kafka.git
13:29:01 > git fetch --tags --progress -- git://github.com/apache/kafka.git +refs/heads/*:refs/remotes/origin/* +refs/pull/*:refs/remotes/origin/pr/*
13:29:17 FATAL: java.io.IOException: Unexpected termination of the channel
13:29:17 java.io.EOFException
13:29:17 at java.io.ObjectInputStream$PeekInputStream.readFully(ObjectInputStream.java:2681)
13:29:17 at java.io.ObjectInputStream$BlockDataInputStream.readShort(ObjectInputStream.java:3156)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe merged pull request #9194: KAFKA-10384: Separate converters from generated messages
Posted by GitBox <gi...@apache.org>.
cmccabe merged pull request #9194:
URL: https://github.com/apache/kafka/pull/9194
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe commented on pull request #9194: KAFKA-10384: Separate converters from generated messages
Posted by GitBox <gi...@apache.org>.
cmccabe commented on pull request #9194:
URL: https://github.com/apache/kafka/pull/9194#issuecomment-676596370
I tested that this works to allow console consumer to run without a jackson dependency.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe commented on pull request #9194: KAFKA-10384: Separate converters from generated messages
Posted by GitBox <gi...@apache.org>.
cmccabe commented on pull request #9194:
URL: https://github.com/apache/kafka/pull/9194#issuecomment-679187796
> Ok, just to make sure I understand [...] Now for a given schema, we will generate SomeMessageData as well as SomeMessageJsonConverter
Right, you got it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org