You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "scala-steward (via GitHub)" <gi...@apache.org> on 2023/05/03 13:12:07 UTC
[GitHub] [daffodil] scala-steward opened a new pull request, #1012: Update Saxon-HE to 12.2
scala-steward opened a new pull request, #1012:
URL: https://github.com/apache/daffodil/pull/1012
## About this PR
📦 Updates [net.sf.saxon:Saxon-HE](https://saxonica.plan.io/projects/saxonmirrorhe/repository) from `12.1` to `12.2`
## Usage
✅ **Please merge!**
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a [`.scala-steward.conf`](https://github.com/scala-steward-org/scala-steward/blob/0642f3c1f70f08a4e493683c38ebaf92310ab7fb/docs/repo-specific-configuration.md) file.
_Have a fantastic day writing Scala!_
<details>
<summary>🔍 Files still referring to the old version number</summary>
The following files still refer to the old version number (12.1).
You might want to review and update them manually.
```
.github/workflows/main.yml
build.sbt
daffodil-core/src/main/scala/org/apache/daffodil/core/compiler/Compiler.scala
daffodil-japi/build.sbt
daffodil-propgen/src/main/resources/org/apache/daffodil/xsd/DFDL_part2_attributes.xsd
daffodil-test/src/test/resources/org/apache/daffodil/section12/aligned_data/Aligned_Data.tdml
daffodil-test/src/test/resources/org/apache/daffodil/section12/aligned_data/BinaryInput_01.tdml
daffodil-test/src/test/resources/org/apache/daffodil/section13/text_number_props/TextNumberPropsUnparse.tdml
```
</details>
<details>
<summary>⚙ Adjust future updates</summary>
Add this to your `.scala-steward.conf` file to ignore future updates of this dependency:
```
updates.ignore = [ { groupId = "net.sf.saxon", artifactId = "Saxon-HE" } ]
```
Or, add this to slow down future updates of this dependency:
```
dependencyOverrides = [{
pullRequests = { frequency = "30 days" },
dependency = { groupId = "net.sf.saxon", artifactId = "Saxon-HE" }
}]
```
</details>
<sup>
labels: library-update, old-version-remains, commit-count:1
</sup>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] stevedlawrence commented on pull request #1012: Update Saxon-HE to 12.2
Posted by "stevedlawrence (via GitHub)" <gi...@apache.org>.
stevedlawrence commented on PR #1012:
URL: https://github.com/apache/daffodil/pull/1012#issuecomment-1533251843
I'm always in favor of removing unneeded dependencies. I assume Xerces doesn't actually need xml-apis for the same reason that Saxon doesn't need it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] tuxji commented on pull request #1012: Update Saxon-HE to 12.2
Posted by "tuxji (via GitHub)" <gi...@apache.org>.
tuxji commented on PR #1012:
URL: https://github.com/apache/daffodil/pull/1012#issuecomment-1533360489
I asked ChatGPT if Xerces needs xml-apis on Java 8 and it said:
> No, Xerces does not require the xml-apis library on Java 8, as the necessary XML APIs are included in the standard Java runtime library. The xml-apis library is typically used to provide a consistent set of XML APIs across different Java versions and implementations, but it is not needed on Java 8.
When I asked ChatGPT if Xerces needs xml-apis at all, here's the last thing it said:
> Xerces is designed to work with xml-apis to provide a complete XML processing solution for Java programs. While it is possible to use Xerces without xml-apis, it may require more work to integrate Xerces with other XML-related libraries that depend on xml-apis.
I suspect the real answer is yes, we can exclude xml-apis from Daffodil's dependencies, but we'd better be prepared to do a lot of testing in diverse environments because the whole point of xml-apis is to provide a consistent set of XML APIs in these diverse environments. Still, Saxon also works in many diverse environments so if it can exclude xml-apis safely, it does seem to me that Daffodil can exclude xml-apis safely too.
BTW, Daffodil brought in Saxon in order to support daffodil-schematron, but Saxon is an XML processor and XSLT transformer just like Xerces. If you want to eliminate as many unneeded dependencies as possible, Daffodil probably could use Saxon instead of Xerces for everything that Daffodil uses Xerces to do. However, you would need to replace all of Daffodil's org.apache.xerces.[*] imports, change some calls, find and fix problems, and do a lot of testing for some dubious benefit (although Saxon is maintained and Xerces is not).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] stevedlawrence merged pull request #1012: Update Saxon-HE to 12.2
Posted by "stevedlawrence (via GitHub)" <gi...@apache.org>.
stevedlawrence merged PR #1012:
URL: https://github.com/apache/daffodil/pull/1012
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] stevedlawrence commented on pull request #1012: Update Saxon-HE to 12.2
Posted by "stevedlawrence (via GitHub)" <gi...@apache.org>.
stevedlawrence commented on PR #1012:
URL: https://github.com/apache/daffodil/pull/1012#issuecomment-1534604000
Agreed about replacing Xerces with Saxon. It's definitely doable, but I don't think it's trivial and I'm not sure removing a dependency is enough motivation.
I'm all for excluding xml-apis with some testing to confirm it doesn't break anything, but we should do that as a separate issue/PR if it's something we think is needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org