You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Yufei Gu (JIRA)" <ji...@apache.org> on 2018/12/03 21:48:00 UTC
[jira] [Commented] (YARN-9041) Optimize
FSPreemptionThread#identifyContainersToPreempt method
[ https://issues.apache.org/jira/browse/YARN-9041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16707857#comment-16707857 ]
Yufei Gu commented on YARN-9041:
--------------------------------
Thanks for the patch. Some nits:
# {{ * @return list preemptable containers}} should be something like {{the list of best preemptable containers for the resource request}}
# We still need some comments in both tests to clarify which logic path the test are for. For example, we can add comments in {{testRelaxLocalityToPreemptLessAM}} to say that it tests the case that there is no less-AM-container solution in the remaining nodes.
> Optimize FSPreemptionThread#identifyContainersToPreempt method
> --------------------------------------------------------------
>
> Key: YARN-9041
> URL: https://issues.apache.org/jira/browse/YARN-9041
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: scheduler preemption
> Reporter: Wanqiang Ji
> Assignee: Wanqiang Ji
> Priority: Major
> Attachments: YARN-9041.001.patch, YARN-9041.002.patch, YARN-9041.003.patch, YARN-9041.004.patch, YARN-9041.005.patch, YARN-9041.006.patch
>
>
> In FSPreemptionThread#identifyContainersToPreempt method, I suggest if AM preemption, and locality relaxation is allowed, then the search space is expanded to all nodes changed to the remaining nodes. The remaining nodes are equal to all nodes minus the potential nodes.
> Judging condition changed to:
> # rr.getRelaxLocality()
> # !ResourceRequest.isAnyLocation(rr.getResourceName())
> # bestContainers != null
> # bestContainers.numAMContainers > 0
> If I understand the deviation, please criticize me. thx~
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org