You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/02/08 08:59:50 UTC

[GitHub] [iotdb] yuqi1129 opened a new pull request #2657: Update user doc

yuqi1129 opened a new pull request #2657:
URL: https://github.com/apache/iotdb/pull/2657


   ## Description
   see https://github.com/apache/iotdb/issues/2656


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] yuqi1129 commented on a change in pull request #2657: [ISSUE-2656] Update GZIP compression type in user doc

Posted by GitBox <gi...@apache.org>.
yuqi1129 commented on a change in pull request #2657:
URL: https://github.com/apache/iotdb/pull/2657#discussion_r572124918



##########
File path: docs/zh/UserGuide/Concept/Compression.md
##########
@@ -28,5 +28,6 @@ IoTDB允许在创建一个时间序列的时候指定该列的压缩方式。现
 * UNCOMPRESSED（不压缩）
 * SNAPPY压缩
 * LZ4压缩
+* GZIP压缩

Review comment:
       Sure




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] HTHou commented on a change in pull request #2657: [ISSUE-2656] Update GZIP compression type in user doc

Posted by GitBox <gi...@apache.org>.
HTHou commented on a change in pull request #2657:
URL: https://github.com/apache/iotdb/pull/2657#discussion_r572041899



##########
File path: docs/zh/UserGuide/Concept/Compression.md
##########
@@ -28,5 +28,6 @@ IoTDB允许在创建一个时间序列的时候指定该列的压缩方式。现
 * UNCOMPRESSED（不压缩）
 * SNAPPY压缩
 * LZ4压缩
+* GZIP压缩

Review comment:
       Please also update the line 26.
   We have 4 compression types now. :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] qiaojialin commented on a change in pull request #2657: [ISSUE-2656] Update GZIP compression type in user doc

Posted by GitBox <gi...@apache.org>.
qiaojialin commented on a change in pull request #2657:
URL: https://github.com/apache/iotdb/pull/2657#discussion_r572518609



##########
File path: docs/zh/UserGuide/Concept/Compression.md
##########
@@ -28,5 +28,6 @@ IoTDB允许在创建一个时间序列的时候指定该列的压缩方式。现
 * UNCOMPRESSED（不压缩）
 * SNAPPY压缩
 * LZ4压缩
+* GZIP压缩

Review comment:
       改成 "有以下几种" 吧。。




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] HTHou merged pull request #2657: [ISSUE-2656] Update GZIP compression type in user doc

Posted by GitBox <gi...@apache.org>.
HTHou merged pull request #2657:
URL: https://github.com/apache/iotdb/pull/2657


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] HTHou commented on a change in pull request #2657: [ISSUE-2656] Update GZIP compression type in user doc

Posted by GitBox <gi...@apache.org>.
HTHou commented on a change in pull request #2657:
URL: https://github.com/apache/iotdb/pull/2657#discussion_r572042447



##########
File path: docs/UserGuide/Concept/Compression.md
##########
@@ -31,4 +31,6 @@ IoTDB allows you to specify the compression method of the column when creating a
 
 * LZ4
 
+* GZIP

Review comment:
       Same. Update the line 26?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] wangchao316 commented on pull request #2657: Update user doc

Posted by GitBox <gi...@apache.org>.
wangchao316 commented on pull request #2657:
URL: https://github.com/apache/iotdb/pull/2657#issuecomment-774995513


   +1


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org