You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2024/03/07 13:34:45 UTC
[I] [C++] Add support for LLD [arrow]
kou opened a new issue, #40400:
URL: https://github.com/apache/arrow/issues/40400
### Describe the enhancement requested
https://lld.llvm.org/
LLD is the LLVM Linker. It's faster than GNU ld.
### Component(s)
C++
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Add support for LLD [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #40400:
URL: https://github.com/apache/arrow/issues/40400#issuecomment-2040757135
Issue resolved by pull request 40927
https://github.com/apache/arrow/pull/40927
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Add support for LLD [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou closed issue #40400: [C++] Add support for LLD
URL: https://github.com/apache/arrow/issues/40400
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Add support for LLD [arrow]
Posted by "cryos (via GitHub)" <gi...@apache.org>.
cryos commented on issue #40400:
URL: https://github.com/apache/arrow/issues/40400#issuecomment-2030182745
As I look at the linker logic I am struck that we could end up trying to use multiple linkers, I was thinking that we might add an option to choose the linker by name, and populate that from the boolean flags. If we want to keep it simple maybe just warn that multiple linkers were selected and that we will use X, where we would then need to determine the default if all, etc. I can put something together and let you both take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Add support for LLD [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #40400:
URL: https://github.com/apache/arrow/issues/40400#issuecomment-2030958732
You're suggesting `ARROW_LINKER=gold|mold|lld` or something instead of `ARROW_USE_LD_GOLD`/`ARROW_USE_MOLD`/`ARROW_USE_LLD`, right?
I'm OK with it. (I don't have a strong opinion for this.)
BTW, I think that we can drop support for `ARROW_USE_LD_GOLD` after we add support for mold and LLD.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Add support for LLD [arrow]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on issue #40400:
URL: https://github.com/apache/arrow/issues/40400#issuecomment-1983760510
> LLD is a drop-in replacement for the GNU linkers that accepts the same command line arguments and linker scripts as GNU.
Do we even need to add anything explicitly if this is the case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Add support for LLD [arrow]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on issue #40400:
URL: https://github.com/apache/arrow/issues/40400#issuecomment-1984981869
Ah I see, I thought it had a setup like mold that pretends to be ld ^^
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Add support for LLD [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #40400:
URL: https://github.com/apache/arrow/issues/40400#issuecomment-1984929034
We need to pass `-fuse-ld=lld` argument to `gcc`/`g++`.
See also: https://gcc.gnu.org/onlinedocs/gcc/Link-Options.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Add support for LLD [arrow]
Posted by "cryos (via GitHub)" <gi...@apache.org>.
cryos commented on issue #40400:
URL: https://github.com/apache/arrow/issues/40400#issuecomment-2032040086
> You're suggesting `ARROW_LINKER=gold|mold|lld` or something instead of `ARROW_USE_LD_GOLD`/`ARROW_USE_MOLD`/`ARROW_USE_LLD`, right? I'm OK with it. (I don't have a strong opinion for this.)
>
Yes, just to ensure we only request one linker, or what I added with a default in an `if`, `elseif` block.
> BTW, I think that we can drop support for `ARROW_USE_LD_GOLD` after we add support for mold and LLD.
Yeah? It does look a little overly complex, but I wasn't sure on the history there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org