[GitHub] [airflow] kumargauravin commented on pull request #10273: Azure Log Aanalytics Workspace Task Logs Ingestion

[GitBox <gi...@apache.org>]

kumargauravin commented on pull request #10273:
URL: https://github.com/apache/airflow/pull/10273#issuecomment-671645954


   Hi,
   
   Let’s set priorities.
   1. Pylint: I will go with the video and see what I understand.
   2. Complete ToDo sections and how we can test it.
   3. What else needs to be done in order to use the PI.
   4. Anything else we require to add to PR. Any other SOP issues you see!
   5. Movement of config to table as per example provided.
   
   Can you contribute also like in any one points like pylint will be helpful.
   Add any missing things and let’s get this close and merged so that we can
   use!!!
   
   Regards,
   Kumar
   
   On Mon, Aug 10, 2020 at 4:18 PM Kamil Breguła <no...@github.com>
   wrote:
   
   > *@mik-laj* commented on this pull request.
   > ------------------------------
   >
   > In airflow/providers/microsoft/azure/hooks/laws.py
   > <https://github.com/apache/airflow/pull/10273#discussion_r468191537>:
   >
   > > +        self.conn_id = remote_conn_id
   > +        self.account_id = account_id
   > +        self.access_key = access_key
   > +        self.table_name = table_name
   > +
   > +    def build_signature(self, date, content_length, method, content_type, resource):
   > +        x_headers = 'x-ms-date:' + date
   > +        string_to_hash = method + "\n" + str(content_length) + "\n" + content_type + "\n" + x_headers + "\n" + resource
   > +        bytes_to_hash = bytes(string_to_hash, encoding="utf-8")
   > +        decoded_key = base64.b64decode(self.access_key)
   > +        encoded_hash = base64.b64encode(
   > +            hmac.new(decoded_key, bytes_to_hash, digestmod=hashlib.sha256).digest()
   > +        ).decode()
   > +        authorization = "SharedKey {}:{}".format(self.account_id, encoded_hash)
   > +        return authorization
   > +
   >
   > In the case of Stackdriver, we used configurations via airflow.cfg. It is
   > easier to use, but it is not a generally accepted rule.
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/airflow/pull/10273#discussion_r468191537>, or
   > unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/ADK64R7FNRVPNAU72DSAPTLSABP2VANCNFSM4PZYJCCQ>
   > .
   >
   -- 
   Regards,
   Kumar Gaurav
   +1 469 354 2101
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org