You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "itholic (via GitHub)" <gi...@apache.org> on 2024/07/22 05:30:07 UTC
[PR] [SPARK-48752][FOLLOWUP][PYTHON][DOCS] Use explicit name for line number in log [spark]
itholic opened a new pull request, #47437:
URL: https://github.com/apache/spark/pull/47437
### What changes were proposed in this pull request?
This PR followups for https://github.com/apache/spark/pull/47145 to rename the log field naming
### Why are the changes needed?
`line_no` is not very intuitive so we better renaming to `line_number` explicitly.
### Does this PR introduce _any_ user-facing change?
No API change, but user-facing log message will be improved
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
The existing CI should pass
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48752][FOLLOWUP][PYTHON][DOCS] Use explicit name for line number in log [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #47437:
URL: https://github.com/apache/spark/pull/47437#discussion_r1686068685
##########
python/pyspark/errors/exceptions/base.py:
##########
@@ -137,11 +137,11 @@ def _log_exception(self) -> None:
if query_context.contextType().name == "DataFrame":
logger = PySparkLogger.getLogger("DataFrameQueryContextLogger")
call_site = query_context.callSite().split(":")
- line_no = call_site[1] if len(call_site) == 2 else ""
+ line_number = call_site[1] if len(call_site) == 2 else ""
Review Comment:
or `line` to be consistent with `SQLQueryContext`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48752][FOLLOWUP][PYTHON][DOCS] Use explicit name for line number in log [spark]
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on PR #47437:
URL: https://github.com/apache/spark/pull/47437#issuecomment-2245918431
Thanks! Merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48752][FOLLOWUP][PYTHON][DOCS] Use explicit name for line number in log [spark]
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #47437:
URL: https://github.com/apache/spark/pull/47437#discussion_r1687272501
##########
python/pyspark/errors/exceptions/base.py:
##########
@@ -137,11 +137,11 @@ def _log_exception(self) -> None:
if query_context.contextType().name == "DataFrame":
logger = PySparkLogger.getLogger("DataFrameQueryContextLogger")
call_site = query_context.callSite().split(":")
- line_no = call_site[1] if len(call_site) == 2 else ""
+ line_number = call_site[1] if len(call_site) == 2 else ""
Review Comment:
`line` sounds good to me. Just applied the comment. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48752][FOLLOWUP][PYTHON][DOCS] Use explicit name for line number in log [spark]
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic closed pull request #47437: [SPARK-48752][FOLLOWUP][PYTHON][DOCS] Use explicit name for line number in log
URL: https://github.com/apache/spark/pull/47437
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48752][FOLLOWUP][PYTHON][DOCS] Use explicit name for line number in log [spark]
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on PR #47437:
URL: https://github.com/apache/spark/pull/47437#issuecomment-2242120624
cc @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48752][FOLLOWUP][PYTHON][DOCS] Use explicit name for line number in log [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #47437:
URL: https://github.com/apache/spark/pull/47437#discussion_r1686067684
##########
python/pyspark/errors/exceptions/base.py:
##########
@@ -137,11 +137,11 @@ def _log_exception(self) -> None:
if query_context.contextType().name == "DataFrame":
logger = PySparkLogger.getLogger("DataFrameQueryContextLogger")
call_site = query_context.callSite().split(":")
- line_no = call_site[1] if len(call_site) == 2 else ""
+ line_number = call_site[1] if len(call_site) == 2 else ""
Review Comment:
What about `lineno` since this is Python specific
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org