[GitHub] stu1130 commented on a change in pull request #13330: [MXNET-1222] Scala Inference "Pandora Box"

[GitBox <gi...@apache.org>]

stu1130 commented on a change in pull request #13330: [MXNET-1222] Scala Inference "Pandora Box"
URL: https://github.com/apache/incubator-mxnet/pull/13330#discussion_r235126257
 
 

 ##########
 File path: scala-package/infer/src/main/scala/org/apache/mxnet/infer/Predictor.scala
 ##########
 @@ -17,12 +17,14 @@
 
 package org.apache.mxnet.infer
 
+import org.apache.mxnet.WarnIfNotDisposed.{logger, traceProperty}
 import org.apache.mxnet.io.NDArrayIter
 import org.apache.mxnet.{Context, DataDesc, NDArray, Shape}
 import org.apache.mxnet.module.Module
 
 import scala.collection.mutable.ListBuffer
 import org.slf4j.LoggerFactory
+import scala.util.Try
 
 
 Review comment:
   should we follow some rules to import the lib in a certain order?
   ```
   ...
   import org.slf4j.LoggerFactory
   
   import scala.collection.mutable.ListBuffer
   import scala.util.Try
   
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services