You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Laurel Hale (Code Review)" <ge...@cloudera.org> on 2017/02/18 01:33:52 UTC

[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream docs. Hid instances of CM and rewrote for upstream docs when necessary. This still leaves occurences of CM in the XML, but not in the rendered documentation. A later project will remove 

Laurel Hale has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/6067

Change subject: IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream docs. Hid instances of CM and rewrote for upstream docs when necessary. This still leaves occurences of CM in the XML, but not in the rendered documentation. A later project will remove
......................................................................

IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream
docs. Hid instances of CM and rewrote for upstream docs when necessary.
This still leaves occurences of CM in the XML, but not in the rendered
documentation. A later project will remove all occurrences of CM from
the XML.

Change-Id: I4748300edc43b7071afc50e7cc7ddd64120c0d8d
---
M docs/topics/impala_impala_shell.xml
M docs/topics/impala_proxy.xml
M docs/topics/impala_resource_management.xml
M docs/topics/impala_timeouts.xml
M docs/topics/impala_udf.xml
5 files changed, 95 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/6067/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4748300edc43b7071afc50e7cc7ddd64120c0d8d
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Laurel Hale <la...@cloudera.com>

[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream docs.

Posted by "Laurel Hale (Code Review)" <ge...@cloudera.org>.
Laurel Hale has posted comments on this change.

Change subject: IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream docs.
......................................................................


Patch Set 2:

Resolved the merge conflict. Please review and if all looks in order, +2 to push to master

-- 
To view, visit http://gerrit.cloudera.org:8080/6067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4748300edc43b7071afc50e7cc7ddd64120c0d8d
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream docs.

Posted by "Ambreen Kazi (Code Review)" <ge...@cloudera.org>.
Ambreen Kazi has posted comments on this change.

Change subject: IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream docs.
......................................................................


Patch Set 2:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/6067/2/docs/topics/impala_proxy.xml
File docs/topics/impala_proxy.xml:

Line 114:                 Consider enabling <q>sticky sessions</q>. <ph rev="upstream">Cloudera</ph> recommends enabling this setting
'Cloudera'


PS2, Line 261: CDH Secu
CDH reference


http://gerrit.cloudera.org:8080/#/c/6067/2/docs/topics/impala_resource_management.xml
File docs/topics/impala_resource_management.xml:

Line 357:       <p rev="2.0.0">
this whole concept is only left with one line -- which isn't even a limitation anymore. Just leaving this comment in case you want to consider hiding the whole concept.


http://gerrit.cloudera.org:8080/#/c/6067/2/docs/topics/impala_timeouts.xml
File docs/topics/impala_timeouts.xml:

PS2, Line 43:  CDH 
Remove CDH.


http://gerrit.cloudera.org:8080/#/c/6067/2/docs/topics/impala_udf.xml
File docs/topics/impala_udf.xml:

Line 425:           Start at <xref href="https://archive.cloudera.com/cdh5/" scope="external" format="html"/> for the CDH 5
Are there links to upstream repos that can replace these?


PS2, Line 433:  CDH 4
CDH4-specific info you could probably delete.


-- 
To view, visit http://gerrit.cloudera.org:8080/6067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4748300edc43b7071afc50e7cc7ddd64120c0d8d
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream docs. Hid instances of CM and rewrote for upstream docs when necessary. This still leaves occurences of CM in the XML, but not in the rendered documentation. A later project will remove

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.

Change subject: IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream docs. Hid instances of CM and rewrote for upstream docs when necessary. This still leaves occurences of CM in the XML, but not in the rendered documentation. A later project will remove
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/6067/1/docs/topics/impala_impala_shell.xml
File docs/topics/impala_impala_shell.xml:

PS1, Line 96:     
Watch out for trailing spaces and/or tabs left behind in new blank lines or newly split lines.

In vi, you can find such things by doing

/[ \t][ \t]*$

which will leave the cursor at the start of whichever sequence of spaces and tabs comes at the end of a line. At that point, you can press D to remove from the cursor position to the end of the line -- i.e. all trailing spaces and tabs.


http://gerrit.cloudera.org:8080/#/c/6067/1/docs/topics/impala_proxy.xml
File docs/topics/impala_proxy.xml:

PS1, Line 336: <li audience="hidden">
Isn't this too blunt an instrument to hide the whole <li>? Everything under here (except little things like the CM-related <note>) is appropriate for generic Apache Impala usage. The <ol>, <codeblock>, etc. are all inside this <li> and will be hidden too.


http://gerrit.cloudera.org:8080/#/c/6067/1/docs/topics/impala_timeouts.xml
File docs/topics/impala_timeouts.xml:

PS1, Line 188: Various client applications
We may as well preserve part of this sentence, at least the example of:

pressing <codeph>^C</codeph> in
        <cmdname>impala-shell</cmdname>

since that's applicable to generic Apache Impala.


-- 
To view, visit http://gerrit.cloudera.org:8080/6067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4748300edc43b7071afc50e7cc7ddd64120c0d8d
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream docs.

Posted by "Laurel Hale (Code Review)" <ge...@cloudera.org>.
Laurel Hale has uploaded a new patch set (#2).

Change subject: IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream docs.
......................................................................

IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream
docs.

Hid instances of CM and rewrote for upstream docs when necessary.
This still leaves occurences of CM in the XML, but not in the rendered
documentation. A later project will remove all occurrences of CM from
the XML. This patch set includes fixes made in response to John
Russell's review.

Change-Id: I4748300edc43b7071afc50e7cc7ddd64120c0d8d
---
M docs/topics/impala_impala_shell.xml
M docs/topics/impala_proxy.xml
M docs/topics/impala_resource_management.xml
M docs/topics/impala_timeouts.xml
M docs/topics/impala_udf.xml
5 files changed, 116 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/6067/2
-- 
To view, visit http://gerrit.cloudera.org:8080/6067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4748300edc43b7071afc50e7cc7ddd64120c0d8d
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>

[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream docs.

Posted by "Laurel Hale (Code Review)" <ge...@cloudera.org>.
Laurel Hale has posted comments on this change.

Change subject: IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream docs.
......................................................................


Patch Set 2:

Please review these so we can get them pushed to master.

-- 
To view, visit http://gerrit.cloudera.org:8080/6067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4748300edc43b7071afc50e7cc7ddd64120c0d8d
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream docs.

Posted by "Laurel Hale (Code Review)" <ge...@cloudera.org>.
Laurel Hale has posted comments on this change.

Change subject: IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream docs.
......................................................................


Patch Set 2:

(8 comments)

Ambreen, I've answered your comments, can you take a look and +1 if all looks in order? Thanks.

http://gerrit.cloudera.org:8080/#/c/6067/1/docs/topics/impala_proxy.xml
File docs/topics/impala_proxy.xml:

PS1, Line 336:         
> Isn't this too blunt an instrument to hide the whole <li>? Everything under
Done


http://gerrit.cloudera.org:8080/#/c/6067/2/docs/topics/impala_proxy.xml
File docs/topics/impala_proxy.xml:

Line 114:                 Consider enabling <q>sticky sessions</q>. <ph rev="upstream">Cloudera</ph> recommends enabling this setting
> 'Cloudera'
John asked me to confine my changes to only addressing the references to "Cloudera Manager." Other proprietary references will be removed in subsequent cleanup tasks.


PS2, Line 261: CDH Secu
> CDH reference
John asked me to confine my changes to only addressing the references to "Cloudera Manager." Other proprietary references will be removed in subsequent cleanup tasks.


http://gerrit.cloudera.org:8080/#/c/6067/2/docs/topics/impala_resource_management.xml
File docs/topics/impala_resource_management.xml:

Line 357:       <p rev="2.0.0">
> this whole concept is only left with one line -- which isn't even a limitat
John asked me to confine my changes to only addressing the references to "Cloudera Manager." Other issues will be addressed in subsequent cleanup tasks.


http://gerrit.cloudera.org:8080/#/c/6067/1/docs/topics/impala_timeouts.xml
File docs/topics/impala_timeouts.xml:

PS1, Line 188: Various client applications
> We may as well preserve part of this sentence, at least the example of:
Done


http://gerrit.cloudera.org:8080/#/c/6067/2/docs/topics/impala_timeouts.xml
File docs/topics/impala_timeouts.xml:

PS2, Line 43:  CDH 
> Remove CDH.
John asked me to confine my changes to only addressing the references to "Cloudera Manager." Other proprietary references will be removed in subsequent cleanup tasks.


http://gerrit.cloudera.org:8080/#/c/6067/2/docs/topics/impala_udf.xml
File docs/topics/impala_udf.xml:

Line 425:           Start at <xref href="https://archive.cloudera.com/cdh5/" scope="external" format="html"/> for the CDH 5
> Are there links to upstream repos that can replace these?
John asked me to confine my changes to only addressing the references to "Cloudera Manager." Other proprietary references will be removed in subsequent cleanup tasks.


PS2, Line 433:  CDH 4
> CDH4-specific info you could probably delete.
John asked me to confine my changes to only addressing the references to "Cloudera Manager." Other proprietary references will be removed in subsequent cleanup tasks.


-- 
To view, visit http://gerrit.cloudera.org:8080/6067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4748300edc43b7071afc50e7cc7ddd64120c0d8d
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream docs.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream docs.
......................................................................


IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream
docs.

Hid instances of CM and rewrote for upstream docs when necessary.
This still leaves occurences of CM in the XML, but not in the rendered
documentation. A later project will remove all occurrences of CM from
the XML.

Change-Id: I4748300edc43b7071afc50e7cc7ddd64120c0d8d
Reviewed-on: http://gerrit.cloudera.org:8080/6067
Reviewed-by: John Russell <jr...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M docs/topics/impala_impala_shell.xml
M docs/topics/impala_proxy.xml
M docs/topics/impala_resource_management.xml
M docs/topics/impala_timeouts.xml
M docs/topics/impala_udf.xml
5 files changed, 124 insertions(+), 4 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  John Russell: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/6067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4748300edc43b7071afc50e7cc7ddd64120c0d8d
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>

[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream docs.

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.

Change subject: IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream docs.
......................................................................


Patch Set 3: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/6067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4748300edc43b7071afc50e7cc7ddd64120c0d8d
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream docs.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream docs.
......................................................................


Patch Set 3:

Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/63/

-- 
To view, visit http://gerrit.cloudera.org:8080/6067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4748300edc43b7071afc50e7cc7ddd64120c0d8d
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream docs.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream docs.
......................................................................


Patch Set 3: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/6067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4748300edc43b7071afc50e7cc7ddd64120c0d8d
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream docs.

Posted by "Laurel Hale (Code Review)" <ge...@cloudera.org>.
Laurel Hale has uploaded a new patch set (#3).

Change subject: IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream docs.
......................................................................

IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream
docs.

Hid instances of CM and rewrote for upstream docs when necessary.
This still leaves occurences of CM in the XML, but not in the rendered
documentation. A later project will remove all occurrences of CM from
the XML.

Change-Id: I4748300edc43b7071afc50e7cc7ddd64120c0d8d
---
M docs/topics/impala_impala_shell.xml
M docs/topics/impala_proxy.xml
M docs/topics/impala_resource_management.xml
M docs/topics/impala_timeouts.xml
M docs/topics/impala_udf.xml
5 files changed, 124 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/6067/3
-- 
To view, visit http://gerrit.cloudera.org:8080/6067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4748300edc43b7071afc50e7cc7ddd64120c0d8d
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>