You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/05/22 04:30:24 UTC

[GitHub] [pulsar] fretiq opened a new pull request #7014: [C++] Expose zstd and Snappy compression to C API

fretiq opened a new pull request #7014:
URL: https://github.com/apache/pulsar/pull/7014


   ### Motivation
   
   I'd like to be able to use zstd and/or Snappy compression with the C API, so I've added them to the `pulsar_compression_type` enum.
   
   ### Modifications
   
   I've added `pulsar_CompressionZSTD` and `pulsar_CompressionSNAPPY` to `pulsar_compression_type`
   
   ### Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ### Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API: no
     - The schema: no
     - The default values of configurations: no
     - The wire protocol: no
     - The rest endpoints: no
     - The admin cli options: no
     - Anything that affects deployment: no
   
   ### Documentation
   
     - Does this pull request introduce a new feature? no
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] codelipenghui commented on pull request #7014: [C++] Expose zstd and Snappy compression to C API

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #7014:
URL: https://github.com/apache/pulsar/pull/7014#issuecomment-638608816


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] codelipenghui merged pull request #7014: [C++] Expose zstd and Snappy compression to C API

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #7014:
URL: https://github.com/apache/pulsar/pull/7014


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] sijie commented on pull request #7014: [C++] Expose zstd and Snappy compression to C API

Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #7014:
URL: https://github.com/apache/pulsar/pull/7014#issuecomment-633837768


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] sijie commented on pull request #7014: [C++] Expose zstd and Snappy compression to C API

Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #7014:
URL: https://github.com/apache/pulsar/pull/7014#issuecomment-636161510


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] codelipenghui commented on pull request #7014: [C++] Expose zstd and Snappy compression to C API

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #7014:
URL: https://github.com/apache/pulsar/pull/7014#issuecomment-638631222


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org