You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/02/24 19:07:29 UTC
[GitHub] [superset] etr2460 edited a comment on pull request #18934: fix(sqllab): Un-render deselected tabs
etr2460 edited a comment on pull request #18934:
URL: https://github.com/apache/superset/pull/18934#issuecomment-1050167242
@ktmud that's an interesting point, although i didn't see any significant perf regression to requiring a rerender in the dom when switching tabs (especially since all the tabs were being rerendered before this change when a tab switch happened).
We could certainly iterate here to try and find the best solution, although i suspect that it's more dependent on the content of each tab (does it have results, has it loaded tables in the selected schema, how long is the query in the ace editor) than the raw number of tabs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org