You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "youngkermit8-coder (via GitHub)" <gi...@apache.org> on 2026/08/10 23:33:46 UTC

[PR] [ISSUE #1522] Validate message size before producer startup [rocketmq-dashboard]

youngkermit8-coder opened a new pull request, #1523:
URL: https://github.com/apache/rocketmq-dashboard/pull/1523

   ## Summary
   
   - encode and validate message bodies before resolving an instance endpoint
   - reject bodies larger than 4 MiB before constructing or starting a producer
   - preserve the inclusive 4 MiB limit and failed-send audit record
   - add regression coverage for multibyte oversized input and the exact boundary
   
   ## Root cause
   
   The body-size guard introduced for #1443 was inside the producer lifecycle after
   `DefaultMQProducer.start()`. Invalid oversized requests therefore still performed
   endpoint resolution and attempted a NameServer connection, and a connection
   failure could mask the intended client-side 400 response.
   
   ## Impact
   
   Oversized requests now fail deterministically with HTTP 400 without any endpoint,
   network, or producer operation. Valid messages at exactly 4 MiB continue through
   the existing send path.
   
   ## Validation
   
   - `RocketMQAdminClientImplTest`: 18 tests passed
   - Maven Checkstyle: 0 violations
   - `mvn -DskipTests package`: passed
   
   The targeted test and package verification were run in an isolated worktree with
   the pending base compilation fix from #1502 applied.
   
   Closes #1522
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ISSUE #1522] Validate message size before producer startup [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins merged PR #1523:
URL: https://github.com/apache/rocketmq-dashboard/pull/1523


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org