You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "JeremyYao (via GitHub)" <gi...@apache.org> on 2025/08/15 20:04:44 UTC
[PR] Update Daffdoil VSCode Documentation to only contain relevant user do… [daffodil-site]
JeremyYao opened a new pull request, #186:
URL: https://github.com/apache/daffodil-site/pull/186
…cumentation for the corresponding release version
PR created per https://github.com/apache/daffodil-vscode/issues/1186.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Daffdoil VSCode Documentation to only contain relevant user do… [daffodil-site]
Posted by "stevedlawrence (via GitHub)" <gi...@apache.org>.
stevedlawrence commented on code in PR #186:
URL: https://github.com/apache/daffodil-site/pull/186#discussion_r2283023359
##########
.github/workflows/update-docs.yml:
##########
@@ -106,13 +106,14 @@ jobs:
if: ${{ inputs.project == 'daffodil-vscode.wiki' }}
run: |
SITE_ROOT=${{ github.workspace }}/site
- DOCS_DIR=$SITE_ROOT/site/docs/vscode/$VERSION
+ DOCS_DIR=$SITE_ROOT/docs/vscode/$VERSION
Review Comment:
I think this change is incorrect? `SITE_ROOT` is the root of the daffodil-site git repo (it's checked out under `${github.workspace}/site` in the first `actions/checkout` action). Within the daffodils-site repo is a `site/` directory where all the website content is stored. So there are two `site`'s in the path to get to where files should go.
I'm not against an update that would make this more clear, it is definitely confusing. But we could just open an issue if we want to do that some other time--doesn't have to be part of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Daffdoil VSCode Documentation to only contain relevant user do… [daffodil-site]
Posted by "JeremyYao (via GitHub)" <gi...@apache.org>.
JeremyYao commented on code in PR #186:
URL: https://github.com/apache/daffodil-site/pull/186#discussion_r2288387170
##########
.github/workflows/update-docs.yml:
##########
@@ -106,13 +106,14 @@ jobs:
if: ${{ inputs.project == 'daffodil-vscode.wiki' }}
run: |
SITE_ROOT=${{ github.workspace }}/site
- DOCS_DIR=$SITE_ROOT/site/docs/vscode/$VERSION
+ DOCS_DIR=$SITE_ROOT/docs/vscode/$VERSION
Review Comment:
Good catch. I was confused about `SITE_ROOT` and didn't realize that `SITE_ROOT` is where the daffodil-site repo is checked out at, requiring two `/site`s.
I force pushed a commit that reverts the changes on this line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Daffdoil VSCode Documentation to only contain relevant user do… [daffodil-site]
Posted by "stevedlawrence (via GitHub)" <gi...@apache.org>.
stevedlawrence merged PR #186:
URL: https://github.com/apache/daffodil-site/pull/186
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org