You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/08/17 18:48:34 UTC

[GitHub] [airflow] nuclearpinguin commented on a change in pull request #5795: [AIRFLOW-5186] Move GCP Translate to core

nuclearpinguin commented on a change in pull request #5795: [AIRFLOW-5186] Move GCP Translate to core
URL: https://github.com/apache/airflow/pull/5795#discussion_r314956330
 
 

 ##########
 File path: airflow/gcp/example_dags/example_speech.py
 ##########
 @@ -29,9 +29,9 @@
 
 from airflow.utils import dates
 from airflow import models
-from airflow.contrib.operators.gcp_text_to_speech_operator import GcpTextToSpeechSynthesizeOperator
-from airflow.contrib.operators.gcp_speech_to_text_operator import GcpSpeechToTextRecognizeSpeechOperator
-from airflow.contrib.operators.gcp_translate_speech_operator import GcpTranslateSpeechOperator
+from airflow.gcp.operators.text_to_speech import GcpTextToSpeechSynthesizeOperator
+from airflow.gcp.operators.speech_to_text import GcpSpeechToTextRecognizeSpeechOperator
 
 Review comment:
   There are two product / APIs:
   - Cloud Text-to-Speech API
   - Cloud Speech-to-Text API
   
   We could put those under "conversation" like here:
   https://cloud.google.com/products/ai/?tab=tab3
   but I am not sure if user will know where to look for the operators.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services