You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/04/22 16:45:49 UTC

[GitHub] [kafka] leonardge opened a new pull request #8533: Fixed bug in log validator tests.

leonardge opened a new pull request #8533:
URL: https://github.com/apache/kafka/pull/8533


   *More detailed description of your change,
   if necessary. The PR title and PR message become
   the squashed commit message, so use a separate
   comment to ping reviewers.*
   
   *Summary of testing strategy (including rationale)
   for the feature or bug fix. Unit and/or integration
   tests are expected for any behaviour change and
   system tests should be considered for larger changes.*
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] leonardge removed a comment on issue #8533: KAFKA-9589: Fixed bug in V2 log validator tests

Posted by GitBox <gi...@apache.org>.
leonardge removed a comment on issue #8533:
URL: https://github.com/apache/kafka/pull/8533#issuecomment-618264854


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] leonardge commented on pull request #8533: KAFKA-9589: Fixed bug in V2 log validator tests

Posted by GitBox <gi...@apache.org>.
leonardge commented on pull request #8533:
URL: https://github.com/apache/kafka/pull/8533#issuecomment-619813438


   The tests that are failing doesn't seem to be relevant to my change which are the following:
   - kafka.api.TransactionsTest.testBumpTransactionalEpoch
   - org.apache.kafka.streams.integration.QueryableStateIntegrationTest.shouldAllowConcurrentAccesses
   - kafka.integration.MetricsDuringTopicCreationDeletionTest.testMetricsDuringTopicCreateDelete
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] stanislavkozlovski commented on issue #8533: KAFKA-9589: Fixed bug in V2 log validator tests

Posted by GitBox <gi...@apache.org>.
stanislavkozlovski commented on issue #8533:
URL: https://github.com/apache/kafka/pull/8533#issuecomment-618264305


   JDK 8 failed with
   ```
   06:01:27 #
   06:01:27 # There is insufficient memory for the Java Runtime Environment to continue.
   06:01:27 # Cannot create GC thread. Out of system resources.
   ```
   
   May be an intermittent issue.
   
   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] leonardge commented on pull request #8533: KAFKA-9589: Fixed bug in V2 log validator tests

Posted by GitBox <gi...@apache.org>.
leonardge commented on pull request #8533:
URL: https://github.com/apache/kafka/pull/8533#issuecomment-620047615


   QueryableStateIntegrationTest.shouldAllowConcurrentAccesses JIRA:
   https://issues.apache.org/jira/browse/KAFKA-9798
   
   MetricsDuringTopicCreationDeletionTest.testMetricsDuringTopicCreateDelete:
   https://issues.apache.org/jira/browse/KAFKA-8706
   
   @ijuma It will be great if you can provide me some pointers on what should I do in this case?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] leonardge edited a comment on pull request #8533: KAFKA-9589: Fixed bug in V2 log validator tests

Posted by GitBox <gi...@apache.org>.
leonardge edited a comment on pull request #8533:
URL: https://github.com/apache/kafka/pull/8533#issuecomment-620047615


   QueryableStateIntegrationTest.shouldAllowConcurrentAccesses JIRA:
   https://issues.apache.org/jira/browse/KAFKA-9798
   
   MetricsDuringTopicCreationDeletionTest.testMetricsDuringTopicCreateDelete JIRA:
   https://issues.apache.org/jira/browse/KAFKA-8706
   
   @ijuma It will be great if you can provide me some pointers on what should I do in this case? Thanks for your help!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] ijuma commented on issue #8533: KAFKA-9589: Fixed bug in V2 log validator tests

Posted by GitBox <gi...@apache.org>.
ijuma commented on issue #8533:
URL: https://github.com/apache/kafka/pull/8533#issuecomment-618192475


   ok to test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] leonardge commented on issue #8533: KAFKA-9589: Fixed bug in V2 log validator tests

Posted by GitBox <gi...@apache.org>.
leonardge commented on issue #8533:
URL: https://github.com/apache/kafka/pull/8533#issuecomment-618264854


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] leonardge commented on pull request #8533: KAFKA-9589: Fixed bug in V2 log validator tests

Posted by GitBox <gi...@apache.org>.
leonardge commented on pull request #8533:
URL: https://github.com/apache/kafka/pull/8533#issuecomment-619397708


   Hi @ijuma it will be great if you can re start the tests. Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] ijuma commented on pull request #8533: KAFKA-9589: Fixed bug in V2 log validator tests

Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #8533:
URL: https://github.com/apache/kafka/pull/8533#issuecomment-619439574


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] ijuma commented on pull request #8533: KAFKA-9589: Fixed bug in V2 log validator tests

Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #8533:
URL: https://github.com/apache/kafka/pull/8533#issuecomment-622662404


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] ijuma commented on pull request #8533: KAFKA-9589: Fixed bug in V2 log validator tests

Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #8533:
URL: https://github.com/apache/kafka/pull/8533#issuecomment-619696479


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] leonardge commented on issue #8533: KAFKA-9589: Fixed bug in V2 log validator tests

Posted by GitBox <gi...@apache.org>.
leonardge commented on issue #8533:
URL: https://github.com/apache/kafka/pull/8533#issuecomment-618229704


   Why is the CI failing?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org