You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Suma Shivaprasad <su...@gmail.com> on 2016/05/05 21:56:07 UTC
Re: Review Request 46731: ATLAS-716 Entity update/delete notifications
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46731/#review131952
-----------------------------------------------------------
client/src/main/java/org/apache/atlas/AtlasClient.java (line 577)
<https://reviews.apache.org/r/46731/#comment195990>
would be better to keep the result consistent for all CRUD operations and standardize as EntityResult
- Suma Shivaprasad
On April 27, 2016, 1:05 p.m., Shwetha GS wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46731/
> -----------------------------------------------------------
>
> (Updated April 27, 2016, 1:05 p.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-716
> https://issues.apache.org/jira/browse/ATLAS-716
>
>
> Repository: atlas
>
>
> Description
> -------
>
> 1. Update/delete entity APIs return list of entities created, updated and deleted
> 2. Listeners are called for all the affected entities
>
>
> Diffs
> -----
>
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java 104c0c5
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 813177f
> addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/hook/SqoopHook.java ab7e6ee
> client/src/main/java/org/apache/atlas/AtlasClient.java be34802
> client/src/main/java/org/apache/atlas/EntityAuditEvent.java 460f708
> client/src/main/java/org/apache/atlas/SerDe.java PRE-CREATION
> client/src/main/java/org/apache/atlas/notification/EntityNotification.java PRE-CREATION
> client/src/main/java/org/apache/atlas/notification/EntityNotificationImpl.java PRE-CREATION
> client/src/main/java/org/apache/atlas/notification/HookNotification.java PRE-CREATION
> client/src/test/java/org/apache/atlas/AtlasClientTest.java 8911bf5
> client/src/test/java/org/apache/atlas/notification/EntityNotificationImplTest.java PRE-CREATION
> client/src/test/java/org/apache/atlas/notification/HookNotificationTest.java PRE-CREATION
> notification/src/main/java/org/apache/atlas/hook/AtlasHook.java 68a868f
> notification/src/main/java/org/apache/atlas/notification/AbstractNotification.java 596f988
> notification/src/main/java/org/apache/atlas/notification/AbstractNotificationConsumer.java 1cadb99
> notification/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java 1f2df3e
> notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java ac285aa
> notification/src/main/java/org/apache/atlas/notification/entity/EntityNotification.java 82a1100
> notification/src/main/java/org/apache/atlas/notification/entity/EntityNotificationImpl.java fda588e
> notification/src/main/java/org/apache/atlas/notification/entity/NotificationEntityChangeListener.java 300cbb5
> notification/src/main/java/org/apache/atlas/notification/hook/HookNotification.java 80c96fa
> notification/src/test/java/org/apache/atlas/notification/NotificationEntityChangeListenerTest.java PRE-CREATION
> notification/src/test/java/org/apache/atlas/notification/entity/EntityNotificationImplTest.java 385c41f
> notification/src/test/java/org/apache/atlas/notification/hook/HookNotificationTest.java 57b0eea
> pom.xml 729b178
> repository/pom.xml 533e48b
> repository/src/main/java/org/apache/atlas/repository/MetadataRepository.java 540c308
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java 5b4bdbf
> repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java 8f11322
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java 369a5d5
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java de29e86
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java a3dc7e5
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 9f69940
> repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java be407a5
> repository/src/test/java/org/apache/atlas/repository/audit/HBaseTestUtils.java 84d7bab
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java ae215f9
> repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java 1f906ed
> server-api/src/main/java/org/apache/atlas/RequestContext.java fa94763
> server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8
> typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 31f157e
> webapp/src/main/java/org/apache/atlas/examples/QuickStart.java 79b8124
> webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java b14aa80
> webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java d6199ab
> webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java 03a0d3f
> webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 54d8d92
> webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 720ce79
> webapp/src/test/java/org/apache/atlas/web/service/CuratorFactoryTest.java 2d510a0
>
> Diff: https://reviews.apache.org/r/46731/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> Shwetha GS
>
>
Re: Review Request 46731: ATLAS-716 Entity update/delete notifications
Posted by Suma Shivaprasad <su...@gmail.com>.
> On May 5, 2016, 9:56 p.m., Suma Shivaprasad wrote:
> > client/src/main/java/org/apache/atlas/AtlasClient.java, line 579
> > <https://reviews.apache.org/r/46731/diff/2/?file=1363301#file1363301line579>
> >
> > would be better to keep the result consistent for all CRUD operations and standardize as EntityResult
The reason I thought its better is we could add optional attributes the json after this and this is more flexible than changing the API later on. Makes sense?
- Suma
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46731/#review131952
-----------------------------------------------------------
On April 27, 2016, 1:05 p.m., Shwetha GS wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46731/
> -----------------------------------------------------------
>
> (Updated April 27, 2016, 1:05 p.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-716
> https://issues.apache.org/jira/browse/ATLAS-716
>
>
> Repository: atlas
>
>
> Description
> -------
>
> 1. Update/delete entity APIs return list of entities created, updated and deleted
> 2. Listeners are called for all the affected entities
>
>
> Diffs
> -----
>
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java 104c0c5
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 813177f
> addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/hook/SqoopHook.java ab7e6ee
> client/src/main/java/org/apache/atlas/AtlasClient.java be34802
> client/src/main/java/org/apache/atlas/EntityAuditEvent.java 460f708
> client/src/main/java/org/apache/atlas/SerDe.java PRE-CREATION
> client/src/main/java/org/apache/atlas/notification/EntityNotification.java PRE-CREATION
> client/src/main/java/org/apache/atlas/notification/EntityNotificationImpl.java PRE-CREATION
> client/src/main/java/org/apache/atlas/notification/HookNotification.java PRE-CREATION
> client/src/test/java/org/apache/atlas/AtlasClientTest.java 8911bf5
> client/src/test/java/org/apache/atlas/notification/EntityNotificationImplTest.java PRE-CREATION
> client/src/test/java/org/apache/atlas/notification/HookNotificationTest.java PRE-CREATION
> notification/src/main/java/org/apache/atlas/hook/AtlasHook.java 68a868f
> notification/src/main/java/org/apache/atlas/notification/AbstractNotification.java 596f988
> notification/src/main/java/org/apache/atlas/notification/AbstractNotificationConsumer.java 1cadb99
> notification/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java 1f2df3e
> notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java ac285aa
> notification/src/main/java/org/apache/atlas/notification/entity/EntityNotification.java 82a1100
> notification/src/main/java/org/apache/atlas/notification/entity/EntityNotificationImpl.java fda588e
> notification/src/main/java/org/apache/atlas/notification/entity/NotificationEntityChangeListener.java 300cbb5
> notification/src/main/java/org/apache/atlas/notification/hook/HookNotification.java 80c96fa
> notification/src/test/java/org/apache/atlas/notification/NotificationEntityChangeListenerTest.java PRE-CREATION
> notification/src/test/java/org/apache/atlas/notification/entity/EntityNotificationImplTest.java 385c41f
> notification/src/test/java/org/apache/atlas/notification/hook/HookNotificationTest.java 57b0eea
> pom.xml 729b178
> repository/pom.xml 533e48b
> repository/src/main/java/org/apache/atlas/repository/MetadataRepository.java 540c308
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java 5b4bdbf
> repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java 8f11322
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java 369a5d5
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java de29e86
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java a3dc7e5
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 9f69940
> repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java be407a5
> repository/src/test/java/org/apache/atlas/repository/audit/HBaseTestUtils.java 84d7bab
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java ae215f9
> repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java 1f906ed
> server-api/src/main/java/org/apache/atlas/RequestContext.java fa94763
> server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8
> typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 31f157e
> webapp/src/main/java/org/apache/atlas/examples/QuickStart.java 79b8124
> webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java b14aa80
> webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java d6199ab
> webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java 03a0d3f
> webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 54d8d92
> webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 720ce79
> webapp/src/test/java/org/apache/atlas/web/service/CuratorFactoryTest.java 2d510a0
>
> Diff: https://reviews.apache.org/r/46731/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> Shwetha GS
>
>
Re: Review Request 46731: ATLAS-716 Entity update/delete notifications
Posted by Shwetha GS <ss...@hortonworks.com>.
> On May 5, 2016, 9:56 p.m., Suma Shivaprasad wrote:
> > client/src/main/java/org/apache/atlas/AtlasClient.java, line 579
> > <https://reviews.apache.org/r/46731/diff/2/?file=1363301#file1363301line579>
> >
> > would be better to keep the result consistent for all CRUD operations and standardize as EntityResult
>
> Suma Shivaprasad wrote:
> The reason I thought its better is we could add optional attributes the json after this and this is more flexible than changing the API later on. Makes sense?
Create API returns EntityResult json. Its just the AtlasClient method that returns list<String>. Returning list<string> makes the interface clear
- Shwetha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46731/#review131952
-----------------------------------------------------------
On May 19, 2016, 5:41 a.m., Shwetha GS wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46731/
> -----------------------------------------------------------
>
> (Updated May 19, 2016, 5:41 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-716
> https://issues.apache.org/jira/browse/ATLAS-716
>
>
> Repository: atlas
>
>
> Description
> -------
>
> 1. Update/delete entity APIs return list of entities created, updated and deleted
> 2. Listeners are called for all the affected entities
>
>
> Diffs
> -----
>
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java 254e150
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 70100f1
> client/src/main/java/org/apache/atlas/AtlasClient.java b3ec95c
> client/src/main/java/org/apache/atlas/EntityAuditEvent.java 460f708
> client/src/main/java/org/apache/atlas/SerDe.java PRE-CREATION
> client/src/test/java/org/apache/atlas/AtlasClientTest.java 0e80573
> notification/src/main/java/org/apache/atlas/notification/MessageVersion.java 3f16a9a
> notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java 384f383
> notification/src/main/java/org/apache/atlas/notification/VersionedMessageDeserializer.java 290be59
> notification/src/main/java/org/apache/atlas/notification/entity/NotificationEntityChangeListener.java 300cbb5
> notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java e8b55ef
> repository/src/main/java/org/apache/atlas/repository/MetadataRepository.java 540c308
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java 5b4bdbf
> repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java 8f11322
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java a9e4f39
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 3604277
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cccafc2
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java df28ab3
> repository/src/main/java/org/apache/atlas/repository/graph/HardDeleteHandler.java f8bbf73
> repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java aa78582
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java a017536
> repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java 3fb128c
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe
> repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java be407a5
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java 1aeedb5
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositoryHardDeleteTest.java d2109d3
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositorySoftDeleteTest.java d9e3ec9
> repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java 1f906ed
> server-api/src/main/java/org/apache/atlas/RequestContext.java b1d87ea
> server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8
> typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 31f157e
> webapp/src/main/java/org/apache/atlas/LocalAtlasClient.java c6ed85d
> webapp/src/main/java/org/apache/atlas/notification/NotificationEntityChangeListener.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 709fec5
> webapp/src/main/java/org/apache/atlas/web/service/ServiceModule.java 0f8bcb1
> webapp/src/test/java/org/apache/atlas/LocalAtlasClientTest.java 7f20652
> webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 6985152
> webapp/src/test/java/org/apache/atlas/notification/NotificationEntityChangeListenerTest.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java aa92bc0
> webapp/src/test/java/org/apache/atlas/web/service/CuratorFactoryTest.java 2d510a0
>
> Diff: https://reviews.apache.org/r/46731/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> Shwetha GS
>
>