You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openoffice.apache.org by bu...@apache.org on 2015/04/05 15:53:01 UTC

review requested: [Issue 95167] XIRR() function gives Err:502 : [Attachment 84632] Patch for finanical.cxx

Driss <dr...@gmail.com> has asked  for review:
Issue 95167: XIRR() function gives Err:502
https://bz.apache.org/ooo/show_bug.cgi?id=95167

Attachment 84632: Patch for finanical.cxx
https://bz.apache.org/ooo/attachment.cgi?id=84632&action=edit

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org


Re: review requested: [Issue 95167] XIRR() function gives Err:502 : [Attachment 84632] Patch for finanical.cxx

Posted by Driss Ben Zoubeir <dr...@gmail.com>.
Hallo Regina,

I am using gcc compiler. I have tested the code under linux and has worked.
Now I will test the code using ::rtl::math::isNan and ::rtl::math::isInf
(But under Ubuntu) and upload new patch.

regards
Driss

2015-04-05 20:07 GMT+02:00 Regina Henschel <rb...@t-online.de>:

> Hi,
>
> bugzilla@apache.org schrieb:
>
>> Driss <dr...@gmail.com> has asked  for review:
>> Issue 95167: XIRR() function gives Err:502
>> https://bz.apache.org/ooo/show_bug.cgi?id=95167
>>
>> Attachment 84632: Patch for finanical.cxx
>> https://bz.apache.org/ooo/attachment.cgi?id=84632&action=edit
>>
>
> It doesn't build with MSVC 9.0 Express.
>
> Compiling: scaddins/source/analysis/financial.cxx
> C:/AOO_debugbuild_420/trunk/main/scaddins/source/analysis/financial.cxx(570)
> : error C3861: 'isnan': identifier not found
> C:/AOO_debugbuild_420/trunk/main/scaddins/source/analysis/financial.cxx(570)
> : error C3861: 'isinf': identifier not found
> C:/AOO_debugbuild_420/trunk/main/scaddins/source/analysis/financial.cxx(570)
> : error C3861: 'isnan': identifier not found
> C:/AOO_debugbuild_420/trunk/main/scaddins/source/analysis/financial.cxx(570)
> : error C3861: 'isinf': identifier not found
> dmake:  Error code 2, while making '../../wntmsci12/slo/financial.obj'
> ERROR: error 65280 occurred while making /cygdrive/c/AOO_debugbuild_
> 420/trunk/main/scaddins/source/analysis
>
> What compiler do you have used for building?
>
> isnan and isinf is not available in the old MSVC. Use ::rtl::math::isNan
> and ::rtl::math::isInf instead.
>
> Perhaps ::boost::math::isinf works too, but I have not tested it.
>
> Kind regards
> Regina
>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
> For additional commands, e-mail: dev-help@openoffice.apache.org
>
>

Re: review requested: [Issue 95167] XIRR() function gives Err:502 : [Attachment 84632] Patch for finanical.cxx

Posted by Regina Henschel <rb...@t-online.de>.
Hi,

bugzilla@apache.org schrieb:
> Driss <dr...@gmail.com> has asked  for review:
> Issue 95167: XIRR() function gives Err:502
> https://bz.apache.org/ooo/show_bug.cgi?id=95167
>
> Attachment 84632: Patch for finanical.cxx
> https://bz.apache.org/ooo/attachment.cgi?id=84632&action=edit

It doesn't build with MSVC 9.0 Express.

Compiling: scaddins/source/analysis/financial.cxx
C:/AOO_debugbuild_420/trunk/main/scaddins/source/analysis/financial.cxx(570) 
: error C3861: 'isnan': identifier not found
C:/AOO_debugbuild_420/trunk/main/scaddins/source/analysis/financial.cxx(570) 
: error C3861: 'isinf': identifier not found
C:/AOO_debugbuild_420/trunk/main/scaddins/source/analysis/financial.cxx(570) 
: error C3861: 'isnan': identifier not found
C:/AOO_debugbuild_420/trunk/main/scaddins/source/analysis/financial.cxx(570) 
: error C3861: 'isinf': identifier not found
dmake:  Error code 2, while making '../../wntmsci12/slo/financial.obj'
ERROR: error 65280 occurred while making 
/cygdrive/c/AOO_debugbuild_420/trunk/main/scaddins/source/analysis

What compiler do you have used for building?

isnan and isinf is not available in the old MSVC. Use ::rtl::math::isNan 
and ::rtl::math::isInf instead.

Perhaps ::boost::math::isinf works too, but I have not tested it.

Kind regards
Regina




---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org