You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/20 03:31:08 UTC
[GitHub] [flink] trushev opened a new pull request, #20314: [hotfix][runtime] Replace com.sun.istack.NotNull with org.jetbrains.annotations.NotNull
trushev opened a new pull request, #20314:
URL: https://github.com/apache/flink/pull/20314
## What is the purpose of the change
I believe `com.sun.istack.NotNull` was accidentally used instead of `org.jetbrains.annotations.NotNull` in testuils
```
$ grep -rw . -e 'import com.sun.istack.NotNull;'
./flink-runtime/src/test/java/org/apache/flink/runtime/operators/testutils/MockEnvironment.java:import com.sun.istack.NotNull;
```
```
$ grep -rw . -e 'import org.jetbrains.annotations.NotNull;'
./flink-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/CassandraConnectorITCase.java:import org.jetbrains.annotations.NotNull;
./flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecSinkITCase.java:import org.jetbrains.annotations.NotNull;
./flink-formats/flink-csv/src/test/java/org/apache/flink/formats/csv/DataStreamCsvITCase.java:import org.jetbrains.annotations.NotNull;
./flink-tests/src/test/java/org/apache/flink/test/checkpointing/RestoreUpgradedJobITCase.java:import org.jetbrains.annotations.NotNull;
./flink-tests/src/test/java/org/apache/flink/test/checkpointing/SavepointFormatITCase.java:import org.jetbrains.annotations.NotNull;
./flink-runtime/src/test/java/org/apache/flink/runtime/operators/coordination/ComponentClosingUtilsTest.java:import org.jetbrains.annotations.NotNull;
```
## Brief change log
Replaced `com.sun.istack.NotNull` with `org.jetbrains.annotations.NotNull` in testuils
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] trushev commented on pull request #20314: [hotfix][runtime] Replace com.sun.istack.NotNull with org.jetbrains.annotations.NotNull
Posted by GitBox <gi...@apache.org>.
trushev commented on PR #20314:
URL: https://github.com/apache/flink/pull/20314#issuecomment-1189849073
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #20314: [hotfix][runtime] Remove com.sun.istack.NotNull from testutils
Posted by GitBox <gi...@apache.org>.
zentol merged PR #20314:
URL: https://github.com/apache/flink/pull/20314
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] trushev commented on a diff in pull request #20314: [hotfix][runtime] Remove com.sun.istack.NotNull from testutils
Posted by GitBox <gi...@apache.org>.
trushev commented on code in PR #20314:
URL: https://github.com/apache/flink/pull/20314#discussion_r925763850
##########
flink-runtime/src/test/java/org/apache/flink/runtime/operators/testutils/MockEnvironment.java:
##########
@@ -57,7 +57,7 @@
import org.apache.flink.util.UserCodeClassLoader;
import org.apache.flink.util.concurrent.Executors;
-import com.sun.istack.NotNull;
+import org.jetbrains.annotations.NotNull;
Review Comment:
Thanks, you are right. Removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #20314: [hotfix][runtime] Replace com.sun.istack.NotNull with org.jetbrains.annotations.NotNull
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20314:
URL: https://github.com/apache/flink/pull/20314#issuecomment-1189780215
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "32e07a9d01a177f4586de8c1a0bd99ad054d708d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "32e07a9d01a177f4586de8c1a0bd99ad054d708d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 32e07a9d01a177f4586de8c1a0bd99ad054d708d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] trushev commented on pull request #20314: [hotfix][runtime] Replace com.sun.istack.NotNull with org.jetbrains.annotations.NotNull
Posted by GitBox <gi...@apache.org>.
trushev commented on PR #20314:
URL: https://github.com/apache/flink/pull/20314#issuecomment-1189975631
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a diff in pull request #20314: [hotfix][runtime] Replace com.sun.istack.NotNull with org.jetbrains.annotations.NotNull
Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #20314:
URL: https://github.com/apache/flink/pull/20314#discussion_r925429140
##########
flink-runtime/src/test/java/org/apache/flink/runtime/operators/testutils/MockEnvironment.java:
##########
@@ -57,7 +57,7 @@
import org.apache.flink.util.UserCodeClassLoader;
import org.apache.flink.util.concurrent.Executors;
-import com.sun.istack.NotNull;
+import org.jetbrains.annotations.NotNull;
Review Comment:
Let's just remove this usage. Such annotation shouldn't be used at all, because for new code we go in with the assumption that nothing is nullable unless it is annotated accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org