[archiva] 03/05: Improving logging statements

[ma...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

martin_s pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/archiva.git

commit e66582f76555138409a8da769f258b53fc81747d
Author: Martin Stockhammer <ma...@apache.org>
AuthorDate: Wed Nov 7 20:18:49 2018 +0100

    Improving logging statements
---
 .../maven2/ArchivaRepositoryConnectorFactory.java    |  3 +++
 .../apache/archiva/repository/maven2/MavenUtil.java  | 20 +++++++++++++++++++-
 2 files changed, 22 insertions(+), 1 deletion(-)

diff --git a/archiva-modules/plugins/maven2-repository/src/main/java/org/apache/archiva/dependency/tree/maven2/ArchivaRepositoryConnectorFactory.java b/archiva-modules/plugins/maven2-repository/src/main/java/org/apache/archiva/dependency/tree/maven2/ArchivaRepositoryConnectorFactory.java
index 4ce243f..dd401ae 100644
--- a/archiva-modules/plugins/maven2-repository/src/main/java/org/apache/archiva/dependency/tree/maven2/ArchivaRepositoryConnectorFactory.java
+++ b/archiva-modules/plugins/maven2-repository/src/main/java/org/apache/archiva/dependency/tree/maven2/ArchivaRepositoryConnectorFactory.java
@@ -34,6 +34,9 @@ import org.eclipse.aether.transfer.NoRepositoryConnectorException;
 import java.util.Collection;
 
 /**
+ *
+ * Creates a dummy connector, if the default connectory factory fails to create one.
+ *
  * @author Olivier Lamy
  * @since 1.4-M3
  */
diff --git a/archiva-modules/plugins/maven2-repository/src/main/java/org/apache/archiva/repository/maven2/MavenUtil.java b/archiva-modules/plugins/maven2-repository/src/main/java/org/apache/archiva/repository/maven2/MavenUtil.java
index f9e6929..95d4df0 100644
--- a/archiva-modules/plugins/maven2-repository/src/main/java/org/apache/archiva/repository/maven2/MavenUtil.java
+++ b/archiva-modules/plugins/maven2-repository/src/main/java/org/apache/archiva/repository/maven2/MavenUtil.java
@@ -39,9 +39,23 @@ import org.eclipse.aether.repository.NoLocalRepositoryManagerException;
 import org.eclipse.aether.spi.connector.RepositoryConnectorFactory;
 import org.eclipse.aether.util.graph.selector.AndDependencySelector;
 import org.eclipse.aether.util.graph.selector.ExclusionDependencySelector;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
+/**
+ * Some static utility methods that are used by different classes.
+ */
 public class MavenUtil {
 
+    static Logger log = LoggerFactory.getLogger(MavenUtil.class);
+
+    /**
+     * Creates a new aether repository system session for the given directory and assigns the
+     * repository to this session.
+     *
+     * @param localRepoDir The repository directory
+     * @return The newly created session object.
+     */
     public static RepositorySystemSession newRepositorySystemSession(String localRepoDir)
     {
         DefaultRepositorySystemSession session = MavenRepositorySystemUtils.newSession( );
@@ -58,12 +72,16 @@ public class MavenUtil {
         }
         catch ( NoLocalRepositoryManagerException e )
         {
-            e.printStackTrace( );
+            log.error("Could not assign the repository manager to the session: {}", e.getMessage(), e);
         }
 
         return session;
     }
 
+    /**
+     * Finds the
+     * @return
+     */
     public static RepositorySystem newRepositorySystem()
     {
         DefaultServiceLocator locator = MavenRepositorySystemUtils.newServiceLocator( );