You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/23 02:22:33 UTC
[GitHub] [pulsar] congbobo184 opened a new pull request #14808: [fix][txn]: fix some exception handle in transaction buffer
congbobo184 opened a new pull request #14808:
URL: https://github.com/apache/pulsar/pull/14808
### Motivation
fix some exception return in transaction buffer
### Modifications
use exception.getCause();
### Verifying this change
add test for it
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
- Does this pull request introduce a new feature? (yes)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui closed pull request #14808: [fix][txn]: fix some exception handle in transaction buffer
Posted by GitBox <gi...@apache.org>.
codelipenghui closed pull request #14808:
URL: https://github.com/apache/pulsar/pull/14808
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #14808: [fix][txn]: fix some exception handle in transaction buffer
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #14808:
URL: https://github.com/apache/pulsar/pull/14808
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on a change in pull request #14808: [fix][txn]: fix some exception handle in transaction buffer
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on a change in pull request #14808:
URL: https://github.com/apache/pulsar/pull/14808#discussion_r833864314
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/TopicTransactionBuffer.java
##########
@@ -342,7 +342,7 @@ public void addFailed(ManagedLedgerException exception, Object ctx) {
}
}).exceptionally(exception -> {
log.error("Transaction {} abort on topic {}.", txnID.toString(), topic.getName());
Review comment:
```suggestion
log.error("Transaction {} abort on topic {}.", txnID.toString(), topic.getName(), exception.getCause());
```
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/TopicTransactionBuffer.java
##########
@@ -296,7 +296,7 @@ public void addFailed(ManagedLedgerException exception, Object ctx) {
}
}).exceptionally(exception -> {
log.error("Transaction {} commit on topic {}.", txnID.toString(), topic.getName(), exception);
Review comment:
```suggestion
log.error("Transaction {} commit on topic {}.", txnID.toString(), topic.getName(), exception.getCause());
```
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/TopicTransactionBuffer.java
##########
@@ -218,7 +218,7 @@ public void recoverExceptionally(Exception e) {
}
}).exceptionally(exception -> {
log.error("Topic {}: TransactionBuffer recover failed", this.topic.getName(), exception);
Review comment:
```suggestion
log.error("Topic {}: TransactionBuffer recover failed", this.topic.getName(), exception.getCause());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #14808: [fix][txn]: fix some exception handle in transaction buffer
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #14808:
URL: https://github.com/apache/pulsar/pull/14808#issuecomment-1076054860
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org