You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2018/10/08 15:48:54 UTC
[kudu-CR] KUDU-2601: correctly print newly created files
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11614
Change subject: KUDU-2601: correctly print newly created files
......................................................................
KUDU-2601: correctly print newly created files
I verified this manually by removing the contents of a data root from a
a cluster and running the `kudu fs update_dirs` tool, checking that it
correctly outputed files that were created when no new directories are
created (whereas before, it would omit printing the new files).
Change-Id: I2ab56f2516a97d4a5aa07451c37a4c39dfa965a4
---
M src/kudu/fs/fs_manager.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/11614/1
--
To view, visit http://gerrit.cloudera.org:8080/11614
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2ab56f2516a97d4a5aa07451c37a4c39dfa965a4
Gerrit-Change-Number: 11614
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR] KUDU-2601: correctly print newly created files
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11614 )
Change subject: KUDU-2601: correctly print newly created files
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11614
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ab56f2516a97d4a5aa07451c37a4c39dfa965a4
Gerrit-Change-Number: 11614
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Fengling Wang <fw...@cloudera.com>
Gerrit-Reviewer: Hexin <yu...@antfin.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 09 Oct 2018 00:43:08 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2601: correctly print newly created files
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11614 )
Change subject: KUDU-2601: correctly print newly created files
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11614/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/11614/1//COMMIT_MSG@11
PS1, Line 11: outputed
nit: output ?
--
To view, visit http://gerrit.cloudera.org:8080/11614
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ab56f2516a97d4a5aa07451c37a4c39dfa965a4
Gerrit-Change-Number: 11614
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Fengling Wang <fw...@cloudera.com>
Gerrit-Reviewer: Hexin <yu...@antfin.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 09 Oct 2018 00:37:13 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2601: correctly print newly created files
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Fengling Wang, Alexey Serbin, Hexin, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11614
to look at the new patch set (#2).
Change subject: KUDU-2601: correctly print newly created files
......................................................................
KUDU-2601: correctly print newly created files
I verified this manually by removing the contents of a data root from a
a cluster and running the `kudu fs update_dirs` tool, checking that it
correctly output files that were created when no new directories are
created (whereas before, it would omit printing the new files).
Change-Id: I2ab56f2516a97d4a5aa07451c37a4c39dfa965a4
---
M src/kudu/fs/fs_manager.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/11614/2
--
To view, visit http://gerrit.cloudera.org:8080/11614
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2ab56f2516a97d4a5aa07451c37a4c39dfa965a4
Gerrit-Change-Number: 11614
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Fengling Wang <fw...@cloudera.com>
Gerrit-Reviewer: Hexin <yu...@antfin.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-2601: correctly print newly created files
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11614 )
Change subject: KUDU-2601: correctly print newly created files
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11614/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/11614/1//COMMIT_MSG@11
PS1, Line 11: output f
> nit: output ?
Done
--
To view, visit http://gerrit.cloudera.org:8080/11614
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ab56f2516a97d4a5aa07451c37a4c39dfa965a4
Gerrit-Change-Number: 11614
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Fengling Wang <fw...@cloudera.com>
Gerrit-Reviewer: Hexin <yu...@antfin.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 09 Oct 2018 00:39:33 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2601: correctly print newly created files
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11614 )
Change subject: KUDU-2601: correctly print newly created files
......................................................................
KUDU-2601: correctly print newly created files
I verified this manually by removing the contents of a data root from a
a cluster and running the `kudu fs update_dirs` tool, checking that it
correctly output files that were created when no new directories are
created (whereas before, it would omit printing the new files).
Change-Id: I2ab56f2516a97d4a5aa07451c37a4c39dfa965a4
Reviewed-on: http://gerrit.cloudera.org:8080/11614
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/fs/fs_manager.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/11614
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2ab56f2516a97d4a5aa07451c37a4c39dfa965a4
Gerrit-Change-Number: 11614
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Fengling Wang <fw...@cloudera.com>
Gerrit-Reviewer: Hexin <yu...@antfin.com>
Gerrit-Reviewer: Kudu Jenkins