You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "yydeng626 (via GitHub)" <gi...@apache.org> on 2024/07/26 05:39:23 UTC
[PR] Fix rewrite test case with the table name case consistency issue [shardingsphere]
yydeng626 opened a new pull request, #32279:
URL: https://github.com/apache/shardingsphere/pull/32279
Fixes #ISSUSE_ID.
Changes proposed in this pull request:
-
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix rewrite test case with the table name case consistency issue [shardingsphere]
Posted by "yydeng626 (via GitHub)" <gi...@apache.org>.
yydeng626 closed pull request #32279: Fix rewrite test case with the table name case consistency issue
URL: https://github.com/apache/shardingsphere/pull/32279
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix rewrite test case with the table name case consistency issue [shardingsphere]
Posted by "yydeng626 (via GitHub)" <gi...@apache.org>.
yydeng626 commented on PR #32279:
URL: https://github.com/apache/shardingsphere/pull/32279#issuecomment-2254767619
The original test cases are correct. However, the table names and field names' casing do not match the previous code format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix rewrite test case with the table name case consistency issue [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #32279:
URL: https://github.com/apache/shardingsphere/pull/32279#issuecomment-2252671964
What is the proposal of this PR, did original test cases run failed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix rewrite test case with the table name case consistency issue [shardingsphere]
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on PR #32279:
URL: https://github.com/apache/shardingsphere/pull/32279#issuecomment-2255711756
Hi @yydeng626, can you explain why change the table name? These uppercase table names are for testing whether sharding can be supported normally in this scenario. I recommend not to adjust them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix rewrite test case with the table name case consistency issue [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #32279:
URL: https://github.com/apache/shardingsphere/pull/32279#issuecomment-2255662804
What is the previous code format, any rule here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org