You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Mona Chitnis <mo...@yahoo.in> on 2014/05/06 05:27:25 UTC
Re: Review Request 18754: OOZIE-1492 HA support for HCat

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18754/#review42239
-----------------------------------------------------------



core/src/main/java/org/apache/oozie/dependency/hcat/SimpleHCatDependencyCache.java
<https://reviews.apache.org/r/18754/#comment76035>

    rename - timeToLive



core/src/main/java/org/apache/oozie/dependency/hcat/SimpleHCatDependencyCache.java
<https://reviews.apache.org/r/18754/#comment76036>

    make sure to remove the printStackTrace in final patch



core/src/main/java/org/apache/oozie/dependency/hcat/SimpleHCatDependencyCache.java
<https://reviews.apache.org/r/18754/#comment76037>

    The synchronized block is going to cause rejection of incoming additions to map. how are you handling that?



core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java
<https://reviews.apache.org/r/18754/#comment76038>

    rename to TTL



core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerService.java
<https://reviews.apache.org/r/18754/#comment76041>

    whitespace



core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerService.java
<https://reviews.apache.org/r/18754/#comment76039>

    whitespace



core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerService.java
<https://reviews.apache.org/r/18754/#comment76040>

    whitespace


- Mona Chitnis


On March 4, 2014, 10:59 p.m., Ryota Egashira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18754/
> -----------------------------------------------------------
> 
> (Updated March 4, 2014, 10:59 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1492
>     https://issues.apache.org/jira/browse/OOZIE-1492
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-1492
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 03a7ed8 
>   core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 2e5cd47 
>   core/src/main/java/org/apache/oozie/dependency/hcat/EhcacheHCatDependencyCache.java 6f127c4 
>   core/src/main/java/org/apache/oozie/dependency/hcat/HCatDependencyCache.java df3afd3 
>   core/src/main/java/org/apache/oozie/dependency/hcat/SimpleHCatDependencyCache.java e8e3ebc 
>   core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java f5304ca 
>   core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java 985dcab 
>   core/src/test/java/org/apache/oozie/command/coord/TestCoordPushDependencyCheckXCommand.java da09727 
>   core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerService.java ef71fb0 
> 
> Diff: https://reviews.apache.org/r/18754/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ryota Egashira
> 
>