You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/09/01 18:05:26 UTC
[GitHub] [superset] jinghua-qa opened a new issue #16552: [edit dataset] error will show if change dataset from edit dataset modal
jinghua-qa opened a new issue #16552:
URL: https://github.com/apache/superset/issues/16552
when i try to change dataset when i am in edit dataset modal, the columns of old dataset and new dataset got messed up and the change are saved to my old dataset, then when i try to do the chart, error msg will show also the dashboard with old dataset is broken.
I think if user is not suppose to change dataset in edit modal we should got warning msg before we save, or maybe disable the drop down list in edit modal so that user wont be able to do the change?
https://user-images.githubusercontent.com/81597121/131720932-f35bb622-0b11-415c-8374-5a8e78c474f5.mov
<img width="1781" alt="Screen Shot 2021-09-01 at 10 40 24 AM" src="https://user-images.githubusercontent.com/81597121/131720950-86b025d5-5e26-412e-b48d-911c498ec7d1.png">
<img width="1792" alt="Screen Shot 2021-09-01 at 10 33 23 AM" src="https://user-images.githubusercontent.com/81597121/131720953-52e92f24-9d77-4e22-9e10-ceabfcaef995.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #16552: [edit dataset] error will show if change dataset from edit dataset modal
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #16552:
URL: https://github.com/apache/superset/issues/16552#issuecomment-910535638
expected behavior: user should use Change dataset modal ONLY to perform task of changing dataset. We do need to add some roadblock to prevent users from coming down the wrong route by adding one line below the dropdown - "Please change dataset in the Change dataset modal. Selecting a different table or dataset will cause error in existing chart and dashboard." (?) something like that...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on issue #16552: [edit dataset] error will show if change dataset from edit dataset modal
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #16552:
URL: https://github.com/apache/superset/issues/16552#issuecomment-910535638
expected behavior: user should use Change dataset modal ONLY to perform task of changing dataset. We do need to add some roadblock to prevent users from coming down the wrong route by adding one line below the dropdown - "Please change dataset in the Change dataset modal. Saving changes with a different table or dataset selected from the dropdown will cause error in existing chart and dashboard." (?) something like that...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org