You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "ismaelricopalasios-maker (via GitHub)" <gi...@apache.org> on 2025/09/11 02:14:04 UTC

[I] ### Inconsistent Text Color Theme Fallback ![category Functionality](https://img.shields.io/badge/Functionality-0284c7) [superset]

ismaelricopalasios-maker opened a new issue, #35100:
URL: https://github.com/apache/superset/issues/35100

   ### Inconsistent Text Color Theme Fallback <sub>![category Functionality](https://img.shields.io/badge/Functionality-0284c7)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   The colorTextSecondary fallback to colorText may result in inconsistent text color behavior when themes are changed.
   
   
   ###### Why this matters
   If colorTextSecondary is undefined in some themes but defined in others, the text color will switch between two different color variables, potentially causing unexpected visual changes.
   
   ###### Suggested change āˆ™ *Feature Preview*
   Use only one theme color variable to ensure consistent behavior across themes:
   ```typescript
   color: ${theme.colorText};
   ```
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice Catch](https://img.shields.io/badge/šŸ‘%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/1b42eaa5-3d9c-416f-bbba-918d78905560/upvote) [![Incorrect](https://img.shields.io/badge/šŸ‘Ž%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/1b42eaa5-3d9c-416f-bbba-918d78905560?what_not_true=true)  [![Not in Scope](https://img.shields.io/badge/šŸ‘Ž%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/1b42eaa5-3d9c-416f-bbba-918d78905560?what_out_of_scope=true) [![Not in coding standard](https://img.shields.io/badge/šŸ‘Ž%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/1b42eaa5-3d9c-416f-bbba-918d78905560?what_not_in_standard=true) [![Other](https://img.shields.io/badge/šŸ‘Ž%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/1b42eaa5-3d9c-416f-bbba-918d78905560)
   </details>
   
   <sub>
   
   šŸ’¬ Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:5985586c-c923-4a33-aa1a-b00072d49bce -->
   
   
   [](5985586c-c923-4a33-aa1a-b00072d49bce)
   
   _Originally posted by @korbit-ai[bot] in https://github.com/apache/superset/pull/35096#discussion_r2337718805_
               


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [I] ### Inconsistent Text Color Theme Fallback ![category Functionality](https://img.shields.io/badge/Functionality-0284c7) [superset]

Posted by "dosubot[bot] (via GitHub)" <gi...@apache.org>.
dosubot[bot] commented on issue #35100:
URL: https://github.com/apache/superset/issues/35100#issuecomment-3277128583

   <!-- Greeting -->
   Hi @ismaelricopalasios-maker! I'm [Dosu](https://go.dosu.dev/dosubot) and Iā€™m helping the superset team.
   
   <!-- Answer -->
   Superset's theming system expects all necessary tokens, like colorText and colorTextSecondary, to be defined in the active theme. There is no fallback logic (such as colorTextSecondary || colorText) implemented in the codebase, and components should not rely on such fallbacks. If a token is missing, the system either uses Ant Design's default or the value is simply absent. This design matches the recommendation to use a single theme color variable for consistent behavior across themes, as relying on fallbacks can cause the kind of visual inconsistencies you described when switching themes. Defining and using only one variable (like theme.colorText) is the intended and most robust approach for consistency across all themes[^1].
   
   [^1]: [Superset Theme System Source](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset-frontend/packages/superset-ui-core/src/theme/Theme.tsx)
   
   
   <!-- Dosu Comment Footer -->
   *To reply, just mention [@dosu](https://go.dosu.dev/dosubot).*
   
   ---
   <sup>How did I do? [Good](https://app.dosu.dev/response-feedback/dbfdeff4-d3be-4544-ade2-2440fea3aff8?feedback_type=great_response) | [Irrelevant](https://app.dosu.dev/response-feedback/dbfdeff4-d3be-4544-ade2-2440fea3aff8?feedback_type=irrelevant_answer) | [Incorrect](https://app.dosu.dev/response-feedback/dbfdeff4-d3be-4544-ade2-2440fea3aff8?feedback_type=incorrect_sources) | [Verbose](https://app.dosu.dev/response-feedback/dbfdeff4-d3be-4544-ade2-2440fea3aff8?feedback_type=too_verbose) | [Hallucination](https://app.dosu.dev/response-feedback/dbfdeff4-d3be-4544-ade2-2440fea3aff8?feedback_type=hallucination) | [Report šŸ›](https://app.dosu.dev/response-feedback/dbfdeff4-d3be-4544-ade2-2440fea3aff8?feedback_type=bug_report) | [Other](https://app.dosu.dev/response-feedback/dbfdeff4-d3be-4544-ade2-2440fea3aff8?feedback_type=other)</sup>&nbsp;&nbsp;[![Chat with Dosu](https://dosu.dev/dosu-chat-badge.svg)](https://app.dosu.dev/a28d3c7e-a9d3-459e-9fb6-3a6f9ff4f357/ask?utm_source=githu
 b)&nbsp;[![Join Discord](https://img.shields.io/badge/join-5865F2?logo=discord&logoColor=white&label=)](https://go.dosu.dev/discord-bot)&nbsp;[![Share on X](https://img.shields.io/badge/X-share-black)](https://twitter.com/intent/tweet?text=%40dosu_ai%20helped%20me%20solve%20this%20issue!&url=https%3A//github.com/apache/superset/issues/35100)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [I] ### Inconsistent Text Color Theme Fallback ![category Functionality](https://img.shields.io/badge/Functionality-0284c7) [superset]

Posted by "ismaelricopalasios-maker (via GitHub)" <gi...@apache.org>.
ismaelricopalasios-maker closed issue #35100: ### Inconsistent Text Color Theme Fallback <sub>![category Functionality](https://img.shields.io/badge/Functionality-0284c7)</sub>
URL: https://github.com/apache/superset/issues/35100


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org