You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Brian Wickman <wi...@apache.org> on 2014/08/29 01:34:21 UTC
Review Request 25175: Fix possible deadlock in
TaskRunner.collect_updates.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25175/
-----------------------------------------------------------
Review request for Aurora.
Bugs: AURORA-669
https://issues.apache.org/jira/browse/AURORA-669
Repository: aurora
Description
-------
Fix possible deadlock in TaskRunner.collect_updates.
Diffs
-----
src/main/python/apache/thermos/core/runner.py ec4cdb788a1e24a590b262ba8dbd044cf31fc198
Diff: https://reviews.apache.org/r/25175/diff/
Testing
-------
Regression test y/n ?
Thanks,
Brian Wickman
Re: Review Request 25175: Fix possible deadlock in
TaskRunner.collect_updates.
Posted by David Robinson <dr...@twitter.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25175/#review52223
-----------------------------------------------------------
src/main/python/apache/thermos/core/runner.py
<https://reviews.apache.org/r/25175/#comment90965>
This changes the return value from 0 to None upon timeout. Perhaps change 'break' to 'return 0'?
- David Robinson
On Aug. 28, 2014, 11:34 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25175/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2014, 11:34 p.m.)
>
>
> Review request for Aurora.
>
>
> Bugs: AURORA-669
> https://issues.apache.org/jira/browse/AURORA-669
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix possible deadlock in TaskRunner.collect_updates.
>
>
> Diffs
> -----
>
> src/main/python/apache/thermos/core/runner.py ec4cdb788a1e24a590b262ba8dbd044cf31fc198
>
> Diff: https://reviews.apache.org/r/25175/diff/
>
>
> Testing
> -------
>
> Regression test y/n ?
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 25175: Fix possible deadlock in
TaskRunner.collect_updates.
Posted by Joe Smith <ya...@gmail.com>.
> On Aug. 28, 2014, 4:49 p.m., Maxim Khutornenko wrote:
> > src/main/python/apache/thermos/core/runner.py, line 821
> > <https://reviews.apache.org/r/25175/diff/1/?file=671859#file671859line821>
> >
> > *Regression test y/n ?*
> > Definitely yes from me.
+1
- Joe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25175/#review51852
-----------------------------------------------------------
On Aug. 28, 2014, 4:34 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25175/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2014, 4:34 p.m.)
>
>
> Review request for Aurora.
>
>
> Bugs: AURORA-669
> https://issues.apache.org/jira/browse/AURORA-669
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix possible deadlock in TaskRunner.collect_updates.
>
>
> Diffs
> -----
>
> src/main/python/apache/thermos/core/runner.py ec4cdb788a1e24a590b262ba8dbd044cf31fc198
>
> Diff: https://reviews.apache.org/r/25175/diff/
>
>
> Testing
> -------
>
> Regression test y/n ?
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 25175: Fix possible deadlock in
TaskRunner.collect_updates.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25175/#review51852
-----------------------------------------------------------
src/main/python/apache/thermos/core/runner.py
<https://reviews.apache.org/r/25175/#comment90476>
*Regression test y/n ?*
Definitely yes from me.
- Maxim Khutornenko
On Aug. 28, 2014, 11:34 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25175/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2014, 11:34 p.m.)
>
>
> Review request for Aurora.
>
>
> Bugs: AURORA-669
> https://issues.apache.org/jira/browse/AURORA-669
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix possible deadlock in TaskRunner.collect_updates.
>
>
> Diffs
> -----
>
> src/main/python/apache/thermos/core/runner.py ec4cdb788a1e24a590b262ba8dbd044cf31fc198
>
> Diff: https://reviews.apache.org/r/25175/diff/
>
>
> Testing
> -------
>
> Regression test y/n ?
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 25175: Fix possible deadlock in
TaskRunner.collect_updates.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25175/#review53385
-----------------------------------------------------------
Ship it!
Please circle back and add test coverage
- Kevin Sweeney
On Sept. 15, 2014, 11:08 a.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25175/
> -----------------------------------------------------------
>
> (Updated Sept. 15, 2014, 11:08 a.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Bugs: AURORA-669
> https://issues.apache.org/jira/browse/AURORA-669
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix possible deadlock in TaskRunner.collect_updates.
>
>
> Diffs
> -----
>
> src/main/python/apache/thermos/core/runner.py ec4cdb788a1e24a590b262ba8dbd044cf31fc198
>
> Diff: https://reviews.apache.org/r/25175/diff/
>
>
> Testing
> -------
>
> Filed https://issues.apache.org/jira/browse/AURORA-709 to track adding test coverage for this.
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 25175: Fix possible deadlock in
TaskRunner.collect_updates.
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25175/#review53367
-----------------------------------------------------------
Ship it!
Ship It!
- Joe Smith
On Sept. 15, 2014, 11:08 a.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25175/
> -----------------------------------------------------------
>
> (Updated Sept. 15, 2014, 11:08 a.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Bugs: AURORA-669
> https://issues.apache.org/jira/browse/AURORA-669
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix possible deadlock in TaskRunner.collect_updates.
>
>
> Diffs
> -----
>
> src/main/python/apache/thermos/core/runner.py ec4cdb788a1e24a590b262ba8dbd044cf31fc198
>
> Diff: https://reviews.apache.org/r/25175/diff/
>
>
> Testing
> -------
>
> Filed https://issues.apache.org/jira/browse/AURORA-709 to track adding test coverage for this.
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 25175: Fix possible deadlock in
TaskRunner.collect_updates.
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25175/
-----------------------------------------------------------
(Updated Sept. 15, 2014, 6:08 p.m.)
Review request for Aurora and Kevin Sweeney.
Changes
-------
Add a committer.
Bugs: AURORA-669
https://issues.apache.org/jira/browse/AURORA-669
Repository: aurora
Description
-------
Fix possible deadlock in TaskRunner.collect_updates.
Diffs
-----
src/main/python/apache/thermos/core/runner.py ec4cdb788a1e24a590b262ba8dbd044cf31fc198
Diff: https://reviews.apache.org/r/25175/diff/
Testing
-------
Filed https://issues.apache.org/jira/browse/AURORA-709 to track adding test coverage for this.
Thanks,
Brian Wickman
Re: Review Request 25175: Fix possible deadlock in
TaskRunner.collect_updates.
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25175/
-----------------------------------------------------------
(Updated Sept. 15, 2014, 6:07 p.m.)
Review request for Aurora.
Bugs: AURORA-669
https://issues.apache.org/jira/browse/AURORA-669
Repository: aurora
Description
-------
Fix possible deadlock in TaskRunner.collect_updates.
Diffs
-----
src/main/python/apache/thermos/core/runner.py ec4cdb788a1e24a590b262ba8dbd044cf31fc198
Diff: https://reviews.apache.org/r/25175/diff/
Testing (updated)
-------
Filed https://issues.apache.org/jira/browse/AURORA-709 to track adding test coverage for this.
Thanks,
Brian Wickman
Re: Review Request 25175: Fix possible deadlock in
TaskRunner.collect_updates.
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25175/
-----------------------------------------------------------
(Updated Sept. 15, 2014, 5:52 p.m.)
Review request for Aurora.
Changes
-------
Address david's feedback.
Bugs: AURORA-669
https://issues.apache.org/jira/browse/AURORA-669
Repository: aurora
Description
-------
Fix possible deadlock in TaskRunner.collect_updates.
Diffs (updated)
-----
src/main/python/apache/thermos/core/runner.py ec4cdb788a1e24a590b262ba8dbd044cf31fc198
Diff: https://reviews.apache.org/r/25175/diff/
Testing
-------
Regression test y/n ?
Thanks,
Brian Wickman