You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/11/08 09:12:51 UTC
[GitHub] [cloudstack] weizhouapache opened a new pull request #5670: server: set network rate for additional public IPs
weizhouapache opened a new pull request #5670:
URL: https://github.com/apache/cloudstack/pull/5670
### Description
This PR fixes #5669
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [x] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5670: server: set network rate for additional public IPs
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5670:
URL: https://github.com/apache/cloudstack/pull/5670#issuecomment-966960688
workaround for #5669 : create port group manually on destination host
for example
```
[root@ref-trl-2125-v-M7-wei-zhou-esxi1:~] esxcli network vswitch standard portgroup add -p clo
ud.public.668.200.1-vSwitch1 -v vSwitch1
[root@ref-trl-2125-v-M7-wei-zhou-esxi1:~] esxcli network vswitch standard portgroup set -p clo
ud.public.668.200.1-vSwitch1 --vlan-id 668
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5670: server: set network rate for additional public IPs
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #5670:
URL: https://github.com/apache/cloudstack/pull/5670#discussion_r745516064
##########
File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
##########
@@ -2069,7 +2068,8 @@ public void prepareAllNicsForMigration(final VirtualMachineProfile vm, final Dep
profile.setIsolationUri(Networks.IsolationType.Vlan.toUri(publicIp.getVlanTag()));
profile.setSecurityGroupEnabled(_networkModel.isSecurityGroupSupportedInNetwork(network));
profile.setName(_networkModel.getNetworkTag(vm.getHypervisorType(), network));
- profile.setNetworId(network.getId());
+ profile.setNetworkRate(_networkModel.getNetworkRate(network.getId(), vm.getId()));
Review comment:
will the network id not be needed anymore?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #5670: server: set network rate for additional public IPs
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #5670:
URL: https://github.com/apache/cloudstack/pull/5670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5670: server: set network rate for additional public IPs
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5670:
URL: https://github.com/apache/cloudstack/pull/5670#issuecomment-963072709
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5670: server: set network rate for additional public IPs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5670:
URL: https://github.com/apache/cloudstack/pull/5670#issuecomment-963921196
@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + vmware-70u1) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5670: server: set network rate for additional public IPs
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #5670:
URL: https://github.com/apache/cloudstack/pull/5670#discussion_r745554649
##########
File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
##########
@@ -2069,7 +2068,8 @@ public void prepareAllNicsForMigration(final VirtualMachineProfile vm, final Dep
profile.setIsolationUri(Networks.IsolationType.Vlan.toUri(publicIp.getVlanTag()));
profile.setSecurityGroupEnabled(_networkModel.isSecurityGroupSupportedInNetwork(network));
profile.setName(_networkModel.getNetworkTag(vm.getHypervisorType(), network));
- profile.setNetworId(network.getId());
+ profile.setNetworkRate(_networkModel.getNetworkRate(network.getId(), vm.getId()));
Review comment:
@DaanHoogland
it is still needed. see line 2072
I changed setNetworId to setNetworkId
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5670: server: set network rate for additional public IPs
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5670:
URL: https://github.com/apache/cloudstack/pull/5670#issuecomment-963920424
@blueorangutan test centos7 vmware-70u1 keepEnv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5670: server: set network rate for additional public IPs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5670:
URL: https://github.com/apache/cloudstack/pull/5670#issuecomment-964409941
<b>Trillian test result (tid-2548)</b>
Environment: vmware-70u1 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33630 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5670-t2548-vmware-70u1.zip
Smoke tests completed. 91 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5670: server: set network rate for additional public IPs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5670:
URL: https://github.com/apache/cloudstack/pull/5670#issuecomment-963075300
@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5670: server: set network rate for additional public IPs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5670:
URL: https://github.com/apache/cloudstack/pull/5670#issuecomment-963632333
@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5670: server: set network rate for additional public IPs
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5670:
URL: https://github.com/apache/cloudstack/pull/5670#issuecomment-963630992
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5670: server: set network rate for additional public IPs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5670:
URL: https://github.com/apache/cloudstack/pull/5670#issuecomment-963654403
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1690
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org