You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2022/07/19 15:11:05 UTC
[GitHub] [daffodil] Shanedell opened a new pull request, #815: Update yarn build command to be yarn package
Shanedell opened a new pull request, #815:
URL: https://github.com/apache/daffodil/pull/815
This is in correlation with https://github.com/apache/daffodil-vscode/pull/232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] Shanedell commented on pull request #815: Update yarn build command to be yarn package
Posted by GitBox <gi...@apache.org>.
Shanedell commented on PR #815:
URL: https://github.com/apache/daffodil/pull/815#issuecomment-1190569963
You are right I actually run in prepackage so it can be removed will do that one oversight on my part
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] stevedlawrence commented on a diff in pull request #815: Update yarn build command to be yarn package
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on code in PR #815:
URL: https://github.com/apache/daffodil/pull/815#discussion_r924670550
##########
containers/release-candidate/daffodil-release-candidate:
##########
@@ -298,7 +298,7 @@ case $PROJECT_REPO in
echo "Building Convenience Binaries..."
mkdir -p $DAFFODIL_RELEASE_DIR/bin/
yarn install
- yarn build
+ yarn package
Review Comment:
Looks like we can remove `yarn install`? Doesn't seem to be needed anymore. I think that was only needed for the os thing which has since been removed/replaced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] Shanedell commented on pull request #815: Update yarn build command to be yarn package
Posted by GitBox <gi...@apache.org>.
Shanedell commented on PR #815:
URL: https://github.com/apache/daffodil/pull/815#issuecomment-1190562021
@stevedlawrence Actually this will still need the yarn install for it to be able to compile the code and run the webpack command I will add it back in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] Shanedell commented on a diff in pull request #815: Update yarn build command to be yarn package
Posted by GitBox <gi...@apache.org>.
Shanedell commented on code in PR #815:
URL: https://github.com/apache/daffodil/pull/815#discussion_r924746783
##########
containers/release-candidate/daffodil-release-candidate:
##########
@@ -298,7 +298,7 @@ case $PROJECT_REPO in
echo "Building Convenience Binaries..."
mkdir -p $DAFFODIL_RELEASE_DIR/bin/
yarn install
- yarn build
+ yarn package
Review Comment:
Oh yeah that is true because the packaging script does run it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] stevedlawrence commented on pull request #815: Update yarn build command to be yarn package
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on PR #815:
URL: https://github.com/apache/daffodil/pull/815#issuecomment-1190568982
> @stevedlawrence Actually this will still need the yarn install for it to be able to compile the code and run the webpack command I will add it back in
The current main branch of the vscode repo works fine for me:
```
git clean -xdf && yarn package
```
I don't get any webpack errors, and it looks like the vsix file was built successfully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] arosien merged pull request #815: Update yarn build command to be yarn package
Posted by GitBox <gi...@apache.org>.
arosien merged PR #815:
URL: https://github.com/apache/daffodil/pull/815
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org