[GitHub] [mynewt-newt] ccollins476ad commented on a change in pull request #321: Add MYNEWT_PROJECT_ROOT env variable

[GitBox <gi...@apache.org>]

ccollins476ad commented on a change in pull request #321: Add MYNEWT_PROJECT_ROOT env variable
URL: https://github.com/apache/mynewt-newt/pull/321#discussion_r312632405
 
 

 ##########
 File path: newt/builder/paths.go
 ##########
 @@ -31,6 +31,10 @@ import (
 const BUILD_NAME_APP = "app"
 const BUILD_NAME_LOADER = "loader"
 
+func ProjectRoot() string {
+	return project.GetProject().Path() + "/"
 
 Review comment:
   Just a nitpick, but I prefer when path strings do not include a trailing slash.  Inevitably, people construct a bigger path by appending "/rest/of/path", and the result is a double slash in the middle of the string.  Also, the other paths in `paths.go` do not include a trailing slash.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services