You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2016/09/23 21:26:11 UTC
[kudu-CR] [c++client] use ATTRIBUTE DEPRECATED attribute
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4529
Change subject: [c++client] use ATTRIBUTE_DEPRECATED attribute
......................................................................
[c++client] use ATTRIBUTE_DEPRECATED attribute
Added the deprecated attribute to the methods/functions marked as such
in the C++ client API.
Also, added -Wdocumentation-deprecated-sync flag to spot cases when
a method marked as deprecated by in-line doc lacks corresponding
deprecation attribute.
Change-Id: I1a48587d1132ada7da63953d7da6cae0f84a0baf
---
M CMakeLists.txt
M src/kudu/client/client.h
M src/kudu/client/schema.h
3 files changed, 33 insertions(+), 19 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/4529/1
--
To view, visit http://gerrit.cloudera.org:8080/4529
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1a48587d1132ada7da63953d7da6cae0f84a0baf
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [c++client] use ATTRIBUTE DEPRECATED attribute
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [c++client] use ATTRIBUTE_DEPRECATED attribute
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4529/2/src/kudu/client/client.h
File src/kudu/client/client.h:
PS2, Line 1710: KuduScanBatch*
Nit: in this case the argument is included in the string, in the others it's not. Why is that?
http://gerrit.cloudera.org:8080/#/c/4529/2/src/kudu/client/schema.h
File src/kudu/client/schema.h:
PS2, Line 88: explicit
Isn't this only desirable for single-arg constructors?
--
To view, visit http://gerrit.cloudera.org:8080/4529
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a48587d1132ada7da63953d7da6cae0f84a0baf
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: Yes
[kudu-CR] [c++client] use ATTRIBUTE DEPRECATED attribute
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [c++client] use ATTRIBUTE_DEPRECATED attribute
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4529
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a48587d1132ada7da63953d7da6cae0f84a0baf
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: No
[kudu-CR] [c++client] use ATTRIBUTE DEPRECATED attribute
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged.
Change subject: [c++client] use ATTRIBUTE_DEPRECATED attribute
......................................................................
[c++client] use ATTRIBUTE_DEPRECATED attribute
Added the deprecated attribute to the methods/functions marked as such
in the C++ client API.
Also, added -Wdocumentation-deprecated-sync flag to spot cases when
a method marked as deprecated by in-line doc lacks corresponding
deprecation attribute (if compiling with clang).
Change-Id: I1a48587d1132ada7da63953d7da6cae0f84a0baf
Reviewed-on: http://gerrit.cloudera.org:8080/4529
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M CMakeLists.txt
M src/kudu/client/client.h
M src/kudu/client/schema.h
3 files changed, 29 insertions(+), 14 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4529
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1a48587d1132ada7da63953d7da6cae0f84a0baf
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
[kudu-CR] [c++client] use ATTRIBUTE DEPRECATED attribute
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [c++client] use ATTRIBUTE_DEPRECATED attribute
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4529/2/src/kudu/client/client.h
File src/kudu/client/client.h:
PS2, Line 1710: KuduScanBatch*
> Nit: in this case the argument is included in the string, in the others it'
Because one can be confused a bit: in this case the deprecated function's name is the same as the function it's obsoleted by. I added the parameter type to resolve the ambiguity.
I'm open to other options here; the only requirements are to report about the deprecated method, suggest the alternative method, and keep the user less frustrated by the message.
http://gerrit.cloudera.org:8080/#/c/4529/2/src/kudu/client/schema.h
File src/kudu/client/schema.h:
PS2, Line 88: explicit
> Isn't this only desirable for single-arg constructors?
Since this is multi-parameter constructor with by-default values, it might happen that one-arg usage will implicitly create an object.
Actually, the Tidy Bot noticed that, not me :)
I'm just addressing its comments.
--
To view, visit http://gerrit.cloudera.org:8080/4529
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a48587d1132ada7da63953d7da6cae0f84a0baf
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: Yes
[kudu-CR] [c++client] use ATTRIBUTE DEPRECATED attribute
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4529
to look at the new patch set (#3).
Change subject: [c++client] use ATTRIBUTE_DEPRECATED attribute
......................................................................
[c++client] use ATTRIBUTE_DEPRECATED attribute
Added the deprecated attribute to the methods/functions marked as such
in the C++ client API.
Also, added -Wdocumentation-deprecated-sync flag to spot cases when
a method marked as deprecated by in-line doc lacks corresponding
deprecation attribute (if compiling with clang).
Change-Id: I1a48587d1132ada7da63953d7da6cae0f84a0baf
---
M CMakeLists.txt
M src/kudu/client/client.h
M src/kudu/client/schema.h
3 files changed, 29 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/4529/3
--
To view, visit http://gerrit.cloudera.org:8080/4529
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1a48587d1132ada7da63953d7da6cae0f84a0baf
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
[kudu-CR] [c++client] use ATTRIBUTE DEPRECATED attribute
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4529
to look at the new patch set (#2).
Change subject: [c++client] use ATTRIBUTE_DEPRECATED attribute
......................................................................
[c++client] use ATTRIBUTE_DEPRECATED attribute
Added the deprecated attribute to the methods/functions marked as such
in the C++ client API.
Also, added -Wdocumentation-deprecated-sync flag to spot cases when
a method marked as deprecated by in-line doc lacks corresponding
deprecation attribute (if compiling with clang).
Change-Id: I1a48587d1132ada7da63953d7da6cae0f84a0baf
---
M CMakeLists.txt
M src/kudu/client/client.h
M src/kudu/client/schema.h
3 files changed, 28 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/4529/2
--
To view, visit http://gerrit.cloudera.org:8080/4529
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1a48587d1132ada7da63953d7da6cae0f84a0baf
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot