[GitHub] [pulsar] codelipenghui commented on a diff in pull request #18980: [cherry-pick][branch-2.10]Fix broker cache eviction of entries read by active cursor

[GitBox <gi...@apache.org>]

codelipenghui commented on code in PR #18980:
URL: https://github.com/apache/pulsar/pull/18980#discussion_r1052815023


##########
conf/broker.conf:
##########
@@ -1481,4 +1481,17 @@ tlsEnabled=false
 
 # Enable Key_Shared subscription (default is enabled)
 # @deprecated since 2.8.0 subscriptionTypesEnabled is preferred over subscriptionKeySharedEnable.
-subscriptionKeySharedEnable=true
\ No newline at end of file
+subscriptionKeySharedEnable=true
+
+# Max number of "acknowledgment holes" that can be stored in Zookeeper. If number of unack message range is higher
+# than this limit then broker will persist unacked ranges into bookkeeper to avoid additional data overhead into
+# zookeeper.
+# Deprecated: use managedLedgerMaxUnackedRangesToPersistInMetadataStore
+managedLedgerMaxUnackedRangesToPersistInZooKeeper=-1
+
+# If enabled, the maximum "acknowledgment holes" will not be limited and "acknowledgment holes" are stored in
+# multiple entries.
+persistentUnackedRangesWithMultipleEntriesEnabled=false

Review Comment:
   They are introduced by #15099 and #15607. 
   We don't need to cherry-pick them to branch-2.10, right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org