You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Jan Luehe (JIRA)" <ji...@apache.org> on 2010/05/20 03:01:54 UTC

[jira] Created: (SHINDIG-1336) Have MutableContent allocate "pipelinedData" (of type java.util.Map) lazily instead of eagerly

Have MutableContent allocate "pipelinedData" (of type java.util.Map) lazily instead of eagerly
----------------------------------------------------------------------------------------------

                 Key: SHINDIG-1336
                 URL: https://issues.apache.org/jira/browse/SHINDIG-1336
             Project: Shindig
          Issue Type: Improvement
          Components: Java
            Reporter: Jan Luehe
            Priority: Minor


The constructors of org.apache.shindig.gadgets.rewrite.MutableContent eagerly allocate "pipelinedData" (of type java.util.Map), which may never be used. MutableContent should allocate its "pipelinedData" field lazily, when addPipelinedData is called for the first time, to avoid unnecessary memory consumption.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SHINDIG-1336) Have MutableContent allocate "pipelinedData" (of type java.util.Map) lazily instead of eagerly

Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Lindner resolved SHINDIG-1336.
-----------------------------------

    Fix Version/s: 2.0.0-RC1
       Resolution: Fixed

committed by john.

> Have MutableContent allocate "pipelinedData" (of type java.util.Map) lazily instead of eagerly
> ----------------------------------------------------------------------------------------------
>
>                 Key: SHINDIG-1336
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1336
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Java
>            Reporter: Jan Luehe
>            Priority: Minor
>             Fix For: 2.0.0-RC1
>
>         Attachments: diffs.txt
>
>
> The constructors of org.apache.shindig.gadgets.rewrite.MutableContent eagerly allocate "pipelinedData" (of type java.util.Map), which may never be used. MutableContent should allocate its "pipelinedData" field lazily, when addPipelinedData is called for the first time, to avoid unnecessary memory consumption.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SHINDIG-1336) Have MutableContent allocate "pipelinedData" (of type java.util.Map) lazily instead of eagerly

Posted by "Jan Luehe (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869661#action_12869661 ] 

Jan Luehe commented on SHINDIG-1336:
------------------------------------

Hi John, I've posted the diffs at http://codereview.appspot.com/1245044/show
Thanks!

> Have MutableContent allocate "pipelinedData" (of type java.util.Map) lazily instead of eagerly
> ----------------------------------------------------------------------------------------------
>
>                 Key: SHINDIG-1336
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1336
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Java
>            Reporter: Jan Luehe
>            Priority: Minor
>         Attachments: diffs.txt
>
>
> The constructors of org.apache.shindig.gadgets.rewrite.MutableContent eagerly allocate "pipelinedData" (of type java.util.Map), which may never be used. MutableContent should allocate its "pipelinedData" field lazily, when addPipelinedData is called for the first time, to avoid unnecessary memory consumption.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SHINDIG-1336) Have MutableContent allocate "pipelinedData" (of type java.util.Map) lazily instead of eagerly

Posted by "John Hjelmstad (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869445#action_12869445 ] 

John Hjelmstad commented on SHINDIG-1336:
-----------------------------------------

Hi Jan: could you post this diff to codereview.appspot.com? Thanks!

> Have MutableContent allocate "pipelinedData" (of type java.util.Map) lazily instead of eagerly
> ----------------------------------------------------------------------------------------------
>
>                 Key: SHINDIG-1336
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1336
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Java
>            Reporter: Jan Luehe
>            Priority: Minor
>         Attachments: diffs.txt
>
>
> The constructors of org.apache.shindig.gadgets.rewrite.MutableContent eagerly allocate "pipelinedData" (of type java.util.Map), which may never be used. MutableContent should allocate its "pipelinedData" field lazily, when addPipelinedData is called for the first time, to avoid unnecessary memory consumption.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SHINDIG-1336) Have MutableContent allocate "pipelinedData" (of type java.util.Map) lazily instead of eagerly

Posted by "Jan Luehe (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jan Luehe updated SHINDIG-1336:
-------------------------------

    Attachment: diffs.txt

> Have MutableContent allocate "pipelinedData" (of type java.util.Map) lazily instead of eagerly
> ----------------------------------------------------------------------------------------------
>
>                 Key: SHINDIG-1336
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1336
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Java
>            Reporter: Jan Luehe
>            Priority: Minor
>         Attachments: diffs.txt
>
>
> The constructors of org.apache.shindig.gadgets.rewrite.MutableContent eagerly allocate "pipelinedData" (of type java.util.Map), which may never be used. MutableContent should allocate its "pipelinedData" field lazily, when addPipelinedData is called for the first time, to avoid unnecessary memory consumption.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.