[jira] [Commented] (HIVE-21435) LlapBaseInputFormat should get task number from TASK_ATTEMPT_ID conf if present, while building SubmitWorkRequestProto

["Gopal V (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-21435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16791386#comment-16791386 ] 

Gopal V commented on HIVE-21435:
--------------------------------

[~ShubhamChaurasia]: for the sake of my sanity, can you write it as a {{final int taskNum}} and assign it in the if() and else()?

So that it is clear which value is set in each case (particularly, if the split has task-num, the attempt is always 0?)

> LlapBaseInputFormat should get task number from TASK_ATTEMPT_ID conf if present, while building SubmitWorkRequestProto
> ----------------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-21435
>                 URL: https://issues.apache.org/jira/browse/HIVE-21435
>             Project: Hive
>          Issue Type: Bug
>          Components: llap
>            Reporter: Shubham Chaurasia
>            Assignee: Shubham Chaurasia
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-21435.1.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently we always pass [split number here as taskNum|https://github.com/apache/hive/blob/master/llap-ext-client/src/java/org/apache/hadoop/hive/llap/LlapBaseInputFormat.java#L185]. However it should be taken from TASK_ATTEMPT_ID conf if it is present.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)