You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "David Van Couvering (JIRA)" <de...@db.apache.org> on 2006/01/20 18:53:45 UTC
[jira] Created: (DERBY-847) Internationalize NetIndoubtTransaction
to NetSqlca in org.apache.derby.client.net
Internationalize NetIndoubtTransaction to NetSqlca in org.apache.derby.client.net
---------------------------------------------------------------------------------
Key: DERBY-847
URL: http://issues.apache.org/jira/browse/DERBY-847
Project: Derby
Type: Sub-task
Reporter: David Van Couvering
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (DERBY-847) Internationalize NetIndoubtTransaction
to NetSqlca in org.apache.derby.client.net
Posted by "David Van Couvering (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-847?page=all ]
David Van Couvering reassigned DERBY-847:
-----------------------------------------
Assign To: David Van Couvering
> Internationalize NetIndoubtTransaction to NetSqlca in org.apache.derby.client.net
> ---------------------------------------------------------------------------------
>
> Key: DERBY-847
> URL: http://issues.apache.org/jira/browse/DERBY-847
> Project: Derby
> Type: Sub-task
> Components: Network Client
> Reporter: David Van Couvering
> Assignee: David Van Couvering
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-847) Internationalize
NetIndoubtTransaction to NetSqlca in org.apache.derby.client.net
Posted by "David Van Couvering (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-847?page=comments#action_12412971 ]
David Van Couvering commented on DERBY-847:
-------------------------------------------
Thanks, Dag, some responses below
<DAG>
* I don't understand the reference to Messages.java; I can't seem to
find that file in the diff.
</DAG>
Sorry, I meant MessageUtil.java
<DAG>
* SQLException.java:
new public method getMessageUtil() lacks java doc. Anyway, good to get rid of those
unneccary objects!
</DAG>
OK, I will add javadoc
<DAG>
* Utils.java:
changed line > 80 long:
SqlException.getMessageUtil().getTextMessage(MessageId.CONN_PRECISION_TOO_LARGE));
</DAG>
OK, will fix
<DAG>
* The way the SQLState constructors are invoked, say, in
NetPackageRequest.java is hard to verify since constructors don't have
javadoc describing how they should be used. In this case an Integer
object is being passed to a constructor that takes an Object in that
position. I would love to see some javadoc as to what objects are
allowed.
</DAG>
Hm, this is pretty standard, it's the way StandardException in the engine works too. Basically, *any* Java object is acceptable. The Java messge formatting code substitutes these objects into the localized message (marked with substitution parameters like {0} and {1}) and invokes the toString() method on them. I can javadoc this though -- but ony for the "main" constructor -- all the other constructors are syntactic sugar that simply delegate to the main constructor.
<DAG>
* NetResultReply.java:
- changed line > 80 characters:
SqlException.getMessageUtil().getTextMessage(MessageId.CONN_CURSOR_NOT_OPEN)));
</DAG>
OK, I'll fix this.
<DAG>
* SQLState.java :
I don't understand why the new SQLState DRDA_CURSOR_NOT_OPEN is not
assigned in the 58 range since it is declared under the header:
"Messages whose SQL states are proscribed by DRDA" and that seem to
be what the range 58 is for; cf. this header in
messages_en.properties:
# 57,58 - DRDA errors with SQLStates required by the spec
and the most other states declared under the same header do have
58... range states. It is listed in messages_en.properties along
with the 2D... range in stead, although with the allocated state
24501.
Disclaimer: I am afraid I don't understand fully how the allocations
are done yet.
</DAG>
Yes, this is all kind of abstruse, and I'm not sure how much I'm supposed to document in the code. DRDA defines very specific SQL States, some starting with 58 and others not, for specific conditions. DRDA requires that the "cursor not open" condition be set to 24501, whereas the "no autocommit under XA" must be set to 2D521. Don't ask me why, I don't know why. It's in the spec. So, anyway, I grouped all SQL States required by the DRDA spec into a single area in SQLState.java.
Is there more I should say in the comments to clarify this?
Thanks,
David
> Internationalize NetIndoubtTransaction to NetSqlca in org.apache.derby.client.net
> ---------------------------------------------------------------------------------
>
> Key: DERBY-847
> URL: http://issues.apache.org/jira/browse/DERBY-847
> Project: Derby
> Type: Sub-task
> Components: Network Client
> Reporter: David Van Couvering
> Assignee: David Van Couvering
> Attachments: DERBY-847-1.diff
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-847) Internationalize
NetIndoubtTransaction to NetSqlca in org.apache.derby.client.net
Posted by "Dag H. Wanvik (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-847?page=comments#action_12413027 ]
Dag H. Wanvik commented on DERBY-847:
-------------------------------------
Thanks for addressing my concerns!
There is one remaining merge conflict section in
java/engine/org/apache/derby/loc/messages_en.properties:
+<<<<<<< .mine
+J128=the cursor is not open
+=======
J128=an Open Query command was issued for a query which was already open
J129=A PROTOCOL Invalid FDOCA Description Error was detected
+>>>>>>> .r408974
While you are at it, my patch checking script found this long line added :-)
++ java/client/org/apache/derby/client/am/CloseFilterInputStream.java (working copy)
SqlException.getMessageUtil().getTextMessage(MessageId.CONN_ALREADY_CLOSED);
As for the grouping, I guess you can just change the header a bit:
# 2D - DRDA exceptions
->
# 2D, 24 - DRDA exceptions
Otherwise, I say it's ready to go!
> Internationalize NetIndoubtTransaction to NetSqlca in org.apache.derby.client.net
> ---------------------------------------------------------------------------------
>
> Key: DERBY-847
> URL: http://issues.apache.org/jira/browse/DERBY-847
> Project: Derby
> Type: Sub-task
> Components: Network Client
> Reporter: David Van Couvering
> Assignee: David Van Couvering
> Attachments: DERBY-847-1.diff, DERBY-847-2.diff
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-847) Internationalize
NetIndoubtTransaction to NetSqlca in org.apache.derby.client.net
Posted by "David Van Couvering (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-847?page=comments#action_12363857 ]
David Van Couvering commented on DERBY-847:
-------------------------------------------
XN451 - XN500
> Internationalize NetIndoubtTransaction to NetSqlca in org.apache.derby.client.net
> ---------------------------------------------------------------------------------
>
> Key: DERBY-847
> URL: http://issues.apache.org/jira/browse/DERBY-847
> Project: Derby
> Type: Sub-task
> Components: Network Client
> Reporter: David Van Couvering
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-847) Internationalize NetIndoubtTransaction
to NetSqlca in org.apache.derby.client.net
Posted by "Mike Matrigali (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-847?page=all ]
Mike Matrigali updated DERBY-847:
---------------------------------
Component: Network Client
Description:
Environment:
> Internationalize NetIndoubtTransaction to NetSqlca in org.apache.derby.client.net
> ---------------------------------------------------------------------------------
>
> Key: DERBY-847
> URL: http://issues.apache.org/jira/browse/DERBY-847
> Project: Derby
> Type: Sub-task
> Components: Network Client
> Reporter: David Van Couvering
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (DERBY-847) Internationalize NetIndoubtTransaction
to NetSqlca in org.apache.derby.client.net
Posted by "David Van Couvering (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-847?page=all ]
David Van Couvering closed DERBY-847:
-------------------------------------
> Internationalize NetIndoubtTransaction to NetSqlca in org.apache.derby.client.net
> ---------------------------------------------------------------------------------
>
> Key: DERBY-847
> URL: http://issues.apache.org/jira/browse/DERBY-847
> Project: Derby
> Type: Sub-task
> Components: Network Client
> Reporter: David Van Couvering
> Assignee: David Van Couvering
> Attachments: DERBY-847-1.diff, DERBY-847-2.diff
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-847) Internationalize NetIndoubtTransaction
to NetSqlca in org.apache.derby.client.net
Posted by "David Van Couvering (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-847?page=all ]
David Van Couvering updated DERBY-847:
--------------------------------------
Attachment: DERBY-847-2.diff
Updated patch which addresses Dag's concerns.
> Internationalize NetIndoubtTransaction to NetSqlca in org.apache.derby.client.net
> ---------------------------------------------------------------------------------
>
> Key: DERBY-847
> URL: http://issues.apache.org/jira/browse/DERBY-847
> Project: Derby
> Type: Sub-task
> Components: Network Client
> Reporter: David Van Couvering
> Assignee: David Van Couvering
> Attachments: DERBY-847-1.diff, DERBY-847-2.diff
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-847) Internationalize NetIndoubtTransaction
to NetSqlca in org.apache.derby.client.net
Posted by "David Van Couvering (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-847?page=all ]
David Van Couvering updated DERBY-847:
--------------------------------------
Attachment: DERBY-847-1.diff
This is for review. derbynetclientmats passes except for the locale error I am getting with sysinfo and a strange error in NSinSameVM which I am working on tracking down.
Besides the i18n of messages for this range, I also added a new static method to SqlException to implement a singleton for the MessageUtil instance configured for the client, so I don't keep creating instances everywhere. I also did a little reformatting of Messages.java so that things were better aligned.
> Internationalize NetIndoubtTransaction to NetSqlca in org.apache.derby.client.net
> ---------------------------------------------------------------------------------
>
> Key: DERBY-847
> URL: http://issues.apache.org/jira/browse/DERBY-847
> Project: Derby
> Type: Sub-task
> Components: Network Client
> Reporter: David Van Couvering
> Assignee: David Van Couvering
> Attachments: DERBY-847-1.diff
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (DERBY-847) Internationalize NetIndoubtTransaction
to NetSqlca in org.apache.derby.client.net
Posted by "David Van Couvering (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-847?page=all ]
David Van Couvering resolved DERBY-847:
---------------------------------------
Resolution: Fixed
Resolved, revision 409037
> Internationalize NetIndoubtTransaction to NetSqlca in org.apache.derby.client.net
> ---------------------------------------------------------------------------------
>
> Key: DERBY-847
> URL: http://issues.apache.org/jira/browse/DERBY-847
> Project: Derby
> Type: Sub-task
> Components: Network Client
> Reporter: David Van Couvering
> Assignee: David Van Couvering
> Attachments: DERBY-847-1.diff, DERBY-847-2.diff
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-847) Internationalize
NetIndoubtTransaction to NetSqlca in org.apache.derby.client.net
Posted by "Dag H. Wanvik (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-847?page=comments#action_12412963 ]
Dag H. Wanvik commented on DERBY-847:
-------------------------------------
I have looked at this patch.
It looks good, I have just some minor comments!
* I don't understand the reference to Messages.java; I can't seem to
find that file in the diff.
* SQLException.java:
new public method getMessageUtil() lacks java doc. Anyway, good to get rid of those
unneccary objects!
* Utils.java:
changed line > 80 long:
SqlException.getMessageUtil().getTextMessage(MessageId.CONN_PRECISION_TOO_LARGE));
* The way the SQLState constructors are invoked, say, in
NetPackageRequest.java is hard to verify since constructors don't have
javadoc describing how they should be used. In this case an Integer
object is being passed to a constructor that takes an Object in that
position. I would love to see some javadoc as to what objects are
allowed.
* NetResultReply.java:
- changed line > 80 characters:
SqlException.getMessageUtil().getTextMessage(MessageId.CONN_CURSOR_NOT_OPEN)));
* SQLState.java :
I don't understand why the new SQLState DRDA_CURSOR_NOT_OPEN is not
assigned in the 58 range since it is declared under the header:
"Messages whose SQL states are proscribed by DRDA" and that seem to
be what the range 58 is for; cf. this header in
messages_en.properties:
# 57,58 - DRDA errors with SQLStates required by the spec
and the most other states declared under the same header do have
58... range states. It is listed in messages_en.properties along
with the 2D... range in stead, although with the allocated state
24501.
Disclaimer: I am afraid I don't understand fully how the allocations
are done yet.
> Internationalize NetIndoubtTransaction to NetSqlca in org.apache.derby.client.net
> ---------------------------------------------------------------------------------
>
> Key: DERBY-847
> URL: http://issues.apache.org/jira/browse/DERBY-847
> Project: Derby
> Type: Sub-task
> Components: Network Client
> Reporter: David Van Couvering
> Assignee: David Van Couvering
> Attachments: DERBY-847-1.diff
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira