[jira] [Comment Edited] (HBASE-20808) Wrong shutdown order between Chores and ChoreService

["Reid Chan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-20808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526377#comment-16526377 ] 

Reid Chan edited comment on HBASE-20808 at 6/28/18 2:42 PM:
------------------------------------------------------------

bq. Shutting down the service is supposed to stop all the chores as well
Yes, you're right.

{code:title=HMaster#stopServiceThreads}
super.stopServiceThreads(); // call choreService shutdown in this method.
stopChores();
{code}
The purpose of this issue is to adjust the call order, or remove the duplicate {{stopChores()}} method.



was (Author: reidchan):
> Shutting down the service is supposed to stop all the chores as well
Yes, you're right.

{code:title=HMaster#stopServiceThreads}
super.stopServiceThreads(); // call choreService shutdown in this method.
stopChores();
{code}
The purpose of this issue is to adjust the call order, or remove the duplicate {{stopChores()}} method.

> Wrong shutdown order between Chores and ChoreService
> ----------------------------------------------------
>
>                 Key: HBASE-20808
>                 URL: https://issues.apache.org/jira/browse/HBASE-20808
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Reid Chan
>            Priority: Minor
>
> When stopping master, {{ChoreService}}, which serves all the chores, is stopped before canceling all running chores.
> It should cancel all running chores, then shutdown {{ChoreService}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)