[GitHub] [airflow] potiuk commented on a change in pull request #19332: Add a skip parameter to Variable to skip the secret backend(s)

[GitBox <gi...@apache.org>]

potiuk commented on a change in pull request #19332:
URL: https://github.com/apache/airflow/pull/19332#discussion_r741681176



##########
File path: airflow/models/variable.py
##########
@@ -124,15 +125,18 @@ def get(
         key: str,
         default_var: Any = __NO_DEFAULT_SENTINEL,
         deserialize_json: bool = False,
+        skip_external_backends: bool = False,

Review comment:
       should we rename it to "skip_secret_backends"? I think this would be more consistent with the currently used naming  
   
   https://airflow.apache.org/docs/apache-airflow/stable/security/secrets/secrets-backend/index.html
   
   For example we can have local FilesystemBackend (which is not `external`). Also it would indicate better the intentions. 
   
   What we want to do by adding the flag we want to explicitly read values that we know are not "secret" and we do not want to look for them in secret backend.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org