You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nutch.apache.org by GitBox <gi...@apache.org> on 2020/07/11 07:38:38 UTC
[GitHub] [nutch] balashashanka opened a new pull request #540: NUTCH-2805: Rename plugin urlfilter-domainblacklist
balashashanka opened a new pull request #540:
URL: https://github.com/apache/nutch/pull/540
As part of NUTCH-2802, the urlfilter-domainblacklist is renamed to "urlfilter-domaindenylist" and all the references and variables have been changed as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nutch] sebastian-nagel commented on a change in pull request #540: NUTCH-2805: Rename plugin urlfilter-domainblacklist
Posted by GitBox <gi...@apache.org>.
sebastian-nagel commented on a change in pull request #540:
URL: https://github.com/apache/nutch/pull/540#discussion_r454274854
##########
File path: src/plugin/urlfilter-domaindenylist/plugin.xml
##########
@@ -16,13 +16,13 @@
limitations under the License.
-->
<plugin
- id="urlfilter-domainblacklist"
- name="Domain Blacklist URL Filter"
+ id="urlfilter-domaindenylist"
+ name="Domain Denylist URL Filter"
version="1.0.0"
provider-name="nutch.org">
<runtime>
- <library name="urlfilter-domainblacklist.jar">
+ <library name="urlfilter-denyblacklist.jar">
Review comment:
Should be "urlfilter-domaindenylist.jar".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nutch] balashashanka commented on a change in pull request #540: NUTCH-2805: Rename plugin urlfilter-domainblacklist
Posted by GitBox <gi...@apache.org>.
balashashanka commented on a change in pull request #540:
URL: https://github.com/apache/nutch/pull/540#discussion_r454429470
##########
File path: src/plugin/urlfilter-domaindenylist/plugin.xml
##########
@@ -16,13 +16,13 @@
limitations under the License.
-->
<plugin
- id="urlfilter-domainblacklist"
- name="Domain Blacklist URL Filter"
+ id="urlfilter-domaindenylist"
+ name="Domain Denylist URL Filter"
version="1.0.0"
provider-name="nutch.org">
<runtime>
- <library name="urlfilter-domainblacklist.jar">
+ <library name="urlfilter-denyblacklist.jar">
Review comment:
Fixed this thanks....now git grep -F "domainblacklist" , just prints the CHANGES.txt since I included the changes to the plugin name and field name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nutch] balashashanka merged pull request #540: NUTCH-2805: Rename plugin urlfilter-domainblacklist
Posted by GitBox <gi...@apache.org>.
balashashanka merged pull request #540:
URL: https://github.com/apache/nutch/pull/540
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org