You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "cstamas (via GitHub)" <gi...@apache.org> on 2025/02/26 10:38:13 UTC
[PR] [MNG-8594] Add atFile option [maven]
cstamas opened a new pull request, #2131:
URL: https://github.com/apache/maven/pull/2131
Where user can create ad-hoc command line parms. The difference between .mvn/maven.conf and this file is that this file allws goals as well. The CLI and atFile are merged, in this order, hence, goals in atFile will come AFTER goals specified on CLI.
---
https://issues.apache.org/jira/browse/MNG-8594
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MNG-8594] Add atFile option [maven]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #2131:
URL: https://github.com/apache/maven/pull/2131#issuecomment-2685183673
@gnodet Added IT, that revealed precedence issue in case of User Properties (`-D`) that was present for maven.config as well, fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MNG-8594] Add atFile option [maven]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on code in PR #2131:
URL: https://github.com/apache/maven/pull/2131#discussion_r1971703182
##########
impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/LayeredOptions.java:
##########
@@ -181,7 +181,9 @@ protected Optional<Map<String, String>> collectMapIfPresentOrEmpty(
Optional<Map<String, String>> up = getter.apply(option);
if (up.isPresent()) {
had++;
- items.putAll(up.get());
Review Comment:
It was putAll, meaning property coming from lower precedence (they are in-order), overwrote already present (higher precedence) property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MNG-8594] Add atFile option [maven]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on PR #2131:
URL: https://github.com/apache/maven/pull/2131#issuecomment-2684989968
Looks good, that can be handy !
Any way to add a small UT or IT maybe ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MNG-8594] Add atFile option [maven]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas merged PR #2131:
URL: https://github.com/apache/maven/pull/2131
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org