You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/11/03 00:59:12 UTC

[GitHub] [beam] tvalentyn commented on a diff in pull request #23947: [Python] Added none check while accessing active_process_bundle

tvalentyn commented on code in PR #23947:
URL: https://github.com/apache/beam/pull/23947#discussion_r1012413214


##########
sdks/python/apache_beam/runners/worker/worker_status.py:
##########
@@ -230,7 +230,7 @@ def close(self):
   def _log_lull_in_bundle_processor(self, bundle_process_cache):
     while True:
       time.sleep(2 * 60)
-      if bundle_process_cache.active_bundle_processors:
+      if not bundle_process_cache and bundle_process_cache.active_bundle_processors:

Review Comment:
   misplaced `not` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org