You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/05/09 14:17:31 UTC

[GitHub] [superset] michael-s-molina commented on pull request #19993: feat(explore): Show confirmation modal if user exits Explore without saving changes

michael-s-molina commented on PR #19993:
URL: https://github.com/apache/superset/pull/19993#issuecomment-1121163148

   @kgabryje If I do more than one change, then the confirmation is not appearing. The `beforeunload` is being unregistered.
   
   https://user-images.githubusercontent.com/70410625/167429669-62e98c72-3812-485a-b74a-74d1795c4b8f.mov
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org