You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@beam.apache.org by Udi Meiri <eh...@google.com> on 2018/09/21 21:10:37 UTC

Python SDK: .options deprecation

Hey, does anybody know why the pipeline.options property was deprecated?
I found this bug: https://issues.apache.org/jira/browse/BEAM-2124
but there's no explanation.

Re: Python SDK: .options deprecation

Posted by Robert Bradshaw <ro...@google.com>.
Correct. Among other things, we don't want to expose the choice of
runner during pipeline construction (perhaps it's even deferred), or
characteristics like streaming vs. batch (the runner should be able to
make this choice on its own). This was not yet pushed all the way
through in Python as it was in Java.
On Mon, Sep 24, 2018 at 6:38 PM Udi Meiri <eh...@google.com> wrote:
>
> Sindy, I don't believe that pipeline.options() works, it's the deprecated @property method.
>
> Ahmet, the first paragraph of this doc seems to have some background about the general direction: https://s.apache.org/no-beam-pipeline
>
>
> On Fri, Sep 21, 2018 at 6:17 PM Ahmet Altay <al...@google.com> wrote:
>>
>> If I remember correctly, this was related to change of the signature of run on runners to run(pipeline, options) instead of just run(pipeline). A runner accepts a pipeline and set of options to run that pipeline, instead of a pipeline and options being a combined thing.
>>
>> It would be good to update the comments or bug with some explanation.
>>
>> On Fri, Sep 21, 2018 at 2:20 PM, Sindy Li <qi...@google.com> wrote:
>>>
>>> I think it's just deprecating referencing the option as
>>>    pipeline.options
>>> , because it is made into a private variable, but we can still do
>>>    pipeline.options()
>>>
>>> On Fri, Sep 21, 2018 at 2:11 PM Udi Meiri <eh...@google.com> wrote:
>>>>
>>>> Hey, does anybody know why the pipeline.options property was deprecated?
>>>> I found this bug: https://issues.apache.org/jira/browse/BEAM-2124
>>>> but there's no explanation.
>>
>>

Re: Python SDK: .options deprecation

Posted by Udi Meiri <eh...@google.com>.
Sindy, I don't believe that pipeline.options() works, it's the deprecated
@property method.

Ahmet, the first paragraph of this doc seems to have some background about
the general direction: https://s.apache.org/no-beam-pipeline


On Fri, Sep 21, 2018 at 6:17 PM Ahmet Altay <al...@google.com> wrote:

> If I remember correctly, this was related to change of the signature of
> run on runners to run(pipeline, options) instead of just run(pipeline). A
> runner accepts a pipeline and set of options to run that pipeline, instead
> of a pipeline and options being a combined thing.
>
> It would be good to update the comments or bug with some explanation.
>
> On Fri, Sep 21, 2018 at 2:20 PM, Sindy Li <qi...@google.com> wrote:
>
>> I think it's just deprecating referencing the option as
>>    pipeline.options
>> , because it is made into a private variable, but we can still do
>>    pipeline.options()
>>
>> On Fri, Sep 21, 2018 at 2:11 PM Udi Meiri <eh...@google.com> wrote:
>>
>>> Hey, does anybody know why the pipeline.options property was deprecated?
>>> I found this bug: https://issues.apache.org/jira/browse/BEAM-2124
>>> but there's no explanation.
>>>
>>
>

Re: Python SDK: .options deprecation

Posted by Ahmet Altay <al...@google.com>.
If I remember correctly, this was related to change of the signature of run
on runners to run(pipeline, options) instead of just run(pipeline). A
runner accepts a pipeline and set of options to run that pipeline, instead
of a pipeline and options being a combined thing.

It would be good to update the comments or bug with some explanation.

On Fri, Sep 21, 2018 at 2:20 PM, Sindy Li <qi...@google.com> wrote:

> I think it's just deprecating referencing the option as
>    pipeline.options
> , because it is made into a private variable, but we can still do
>    pipeline.options()
>
> On Fri, Sep 21, 2018 at 2:11 PM Udi Meiri <eh...@google.com> wrote:
>
>> Hey, does anybody know why the pipeline.options property was deprecated?
>> I found this bug: https://issues.apache.org/jira/browse/BEAM-2124
>> but there's no explanation.
>>
>

Re: Python SDK: .options deprecation

Posted by Sindy Li <qi...@google.com>.
I think it's just deprecating referencing the option as
   pipeline.options
, because it is made into a private variable, but we can still do
   pipeline.options()

On Fri, Sep 21, 2018 at 2:11 PM Udi Meiri <eh...@google.com> wrote:

> Hey, does anybody know why the pipeline.options property was deprecated?
> I found this bug: https://issues.apache.org/jira/browse/BEAM-2124
> but there's no explanation.
>