You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by ro...@apache.org on 2017/09/07 16:44:30 UTC
[1/2] beam git commit: Closes #3805
Repository: beam
Updated Branches:
refs/heads/master df1476d82 -> bd4eab032
Closes #3805
Project: http://git-wip-us.apache.org/repos/asf/beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/bd4eab03
Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/bd4eab03
Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/bd4eab03
Branch: refs/heads/master
Commit: bd4eab03203cfb4d8cc338db08ae1b9358ca2242
Parents: df1476d 8f7ffa4
Author: Robert Bradshaw <ro...@gmail.com>
Authored: Thu Sep 7 09:44:19 2017 -0700
Committer: Robert Bradshaw <ro...@gmail.com>
Committed: Thu Sep 7 09:44:19 2017 -0700
----------------------------------------------------------------------
sdks/python/apache_beam/transforms/core.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
[2/2] beam git commit: Fix typo in variable name: window_fn -->
windowfn
Posted by ro...@apache.org.
Fix typo in variable name: window_fn --> windowfn
`window_fn` is an undefined name in this context while `windowfn` is a parameter to this function and is used in three lines above and the line just after.
Project: http://git-wip-us.apache.org/repos/asf/beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/8f7ffa4c
Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/8f7ffa4c
Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/8f7ffa4c
Branch: refs/heads/master
Commit: 8f7ffa4c36a9bccdc433b701e5788864fb6748e3
Parents: df1476d
Author: cclauss <cc...@bluewin.ch>
Authored: Sun Sep 3 20:10:52 2017 +0200
Committer: Robert Bradshaw <ro...@gmail.com>
Committed: Thu Sep 7 09:44:19 2017 -0700
----------------------------------------------------------------------
sdks/python/apache_beam/transforms/core.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/beam/blob/8f7ffa4c/sdks/python/apache_beam/transforms/core.py
----------------------------------------------------------------------
diff --git a/sdks/python/apache_beam/transforms/core.py b/sdks/python/apache_beam/transforms/core.py
index 7f655a7..ceaa60a 100644
--- a/sdks/python/apache_beam/transforms/core.py
+++ b/sdks/python/apache_beam/transforms/core.py
@@ -1360,7 +1360,7 @@ class Windowing(object):
if not windowfn.get_window_coder().is_deterministic():
raise ValueError(
'window fn (%s) does not have a determanistic coder (%s)' % (
- window_fn, windowfn.get_window_coder()))
+ windowfn, windowfn.get_window_coder()))
self.windowfn = windowfn
self.triggerfn = triggerfn
self.accumulation_mode = accumulation_mode