You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/10/20 07:27:45 UTC

[GitHub] [incubator-nuttx] YuuichiNakamura opened a new pull request #2043: Add SCHED_INSTRUMENTATION_HIRES support

YuuichiNakamura opened a new pull request #2043:
URL: https://github.com/apache/incubator-nuttx/pull/2043


   ## Summary
   If the architecture supports CONFIG_RTC_HIRES, use high resolution RTC instead of ticks for instrumentation.
   
   ## Impact
   CONFIG_SCHED_INSTRUMENTATION_HIRES will be added.
   The option is available only when CONFIG_RTC_HIRES and CONFIG_SCHED_INSTRUMENTATION are enabled.
   
   ## Testing
   Tested with spresense:smp
   CONFIG_RTC_HIRES=y
   CONFIG_RTC_FREQUENCY=32768
   CONFIG_SCHED_INSTRUMENTATION_HIRES=y
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2043: Add SCHED_INSTRUMENTATION_HIRES support

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #2043:
URL: https://github.com/apache/incubator-nuttx/pull/2043#discussion_r508322454



##########
File path: sched/Kconfig
##########
@@ -990,6 +990,14 @@ config SCHED_INSTRUMENTATION_IRQHANDLER
 
 			void sched_note_irqhandler(int irq, FAR void *handler, bool enter);
 
+config SCHED_INSTRUMENTATION_HIRES
+	bool "Use Hi-Res RTC for instrumentation"
+	depends on RTC_HIRES

Review comment:
       should we decopule SCHED_INSTRUMENTATION_HIRES from RTC_HIRES? since many system timer support the microsecond now, on the other hand, ony few RTC support the high resolution.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2043: Add SCHED_INSTRUMENTATION_HIRES support

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #2043:
URL: https://github.com/apache/incubator-nuttx/pull/2043#discussion_r508522931



##########
File path: sched/sched/sched_note.c
##########
@@ -28,6 +28,9 @@
 #include <string.h>
 #include <assert.h>
 #include <errno.h>
+#ifdef CONFIG_SCHED_INSTRUMENTATION_HIRES

Review comment:
       could we remove #ifdef/#endif here? since line 37 don't use condition preprocess.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2043: Add SCHED_INSTRUMENTATION_HIRES support

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #2043:
URL: https://github.com/apache/incubator-nuttx/pull/2043


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2043: Add SCHED_INSTRUMENTATION_HIRES support

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #2043:
URL: https://github.com/apache/incubator-nuttx/pull/2043#discussion_r508522931



##########
File path: sched/sched/sched_note.c
##########
@@ -28,6 +28,9 @@
 #include <string.h>
 #include <assert.h>
 #include <errno.h>
+#ifdef CONFIG_SCHED_INSTRUMENTATION_HIRES

Review comment:
       could we remove #ifdef/#endif here? since line 37 don't use condition preprocess




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org