You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by danieljimenez <gi...@git.apache.org> on 2018/08/04 16:14:50 UTC

[GitHub] nifi pull request #2936: NIFI-5489: Add expression language support to AMQP ...

GitHub user danieljimenez opened a pull request:

    https://github.com/apache/nifi/pull/2936

    NIFI-5489: Add expression language support to AMQP processors HOST, V…

    …HOST and USER Fields.
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [x] Have you written or updated unit tests to verify your changes?
    - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [x] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [x] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [x] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [x] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/danieljimenez/nifi NIFI-5489-amqp-attribute-expression-support

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2936.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2936
    
----
commit 1a9c9d5cd8759125ec344a9ad389b282fb40267d
Author: Daniel Jimenez <da...@...>
Date:   2018-08-04T16:11:28Z

    NIFI-5489: Add expression language support to AMQP processors HOST, VHOST and USER Fields.

----


---

[GitHub] nifi issue #2936: NIFI-5489: Add expression language support to AMQP process...

Posted by danieljimenez <gi...@git.apache.org>.

Github user danieljimenez commented on the issue:

    https://github.com/apache/nifi/pull/2936
  
    Missed a spot evaluating the attribute expressions. Fixed.


---

[GitHub] nifi issue #2936: NIFI-5489: Add expression language support to AMQP process...

Posted by mosermw <gi...@git.apache.org>.

Github user mosermw commented on the issue:

    https://github.com/apache/nifi/pull/2936
  
    +1 from me, though I didn't test this against a real RabbitMQ server.  @zenfenan did you want to take another look?


---

[GitHub] nifi issue #2936: NIFI-5489: Add expression language support to AMQP process...

Posted by alopresto <gi...@git.apache.org>.

Github user alopresto commented on the issue:

    https://github.com/apache/nifi/pull/2936
  
    Hi @lukepfarrar , we have a policy of not evaluating EL in password fields. Here is [an example of that review process](https://github.com/apache/nifi/pull/3020#discussion_r219712821) and the reasoning behind it on another PR. 
    
    > Our policy so far has been that passwords do not support expression language, for a couple reasons:
    > 1. How to evaluate if a password `abc${def}` should be interpreted as `abc` + *the value of(`def`)* or the literal string `abc${def}`
    > 1. The variable registry is not designed to store sensitive values securely, so if a password is stored here, it can be accessed by an unauthorized user


---

[GitHub] nifi issue #2936: NIFI-5489: Add expression language support to AMQP process...

Posted by danieljimenez <gi...@git.apache.org>.

Github user danieljimenez commented on the issue:

    https://github.com/apache/nifi/pull/2936
  
    No idea what the travis failures are, they are definitely not related to this change.


---

[GitHub] nifi issue #2936: NIFI-5489: Add expression language support to AMQP process...

Posted by danieljimenez <gi...@git.apache.org>.

Github user danieljimenez commented on the issue:

    https://github.com/apache/nifi/pull/2936
  
    After rerunning the Travis failures are gone.


---

[GitHub] nifi issue #2936: NIFI-5489: Add expression language support to AMQP process...

Posted by alopresto <gi...@git.apache.org>.

Github user alopresto commented on the issue:

    https://github.com/apache/nifi/pull/2936
  
    There are definitely inconsistencies throughout the project as this wasn't always a firm policy and there are many different contributors to the project. As you noted, we have tried to tighten the reviews and catch this where we can, and hopefully with the completion of [NIFI-5627](https://issues.apache.org/jira/browse/NIFI-5627), we will have a foundation to move forward on enabling EL in passwords for users. 


---

[GitHub] nifi issue #2936: NIFI-5489: Add expression language support to AMQP process...

Posted by mosermw <gi...@git.apache.org>.

Github user mosermw commented on the issue:

    https://github.com/apache/nifi/pull/2936
  
    If you are using VARIABLE_REGISTRY to dynamically evaluate the Host, shouldn't you also allow it for Port?


---

[GitHub] nifi issue #2936: NIFI-5489: Add expression language support to AMQP process...

Posted by danieljimenez <gi...@git.apache.org>.

Github user danieljimenez commented on the issue:

    https://github.com/apache/nifi/pull/2936
  
    Awesome, thanks! That would mean it's targeted for 1.8.0, correct?


---

[GitHub] nifi issue #2936: NIFI-5489: Add expression language support to AMQP process...

Posted by danieljimenez <gi...@git.apache.org>.

Github user danieljimenez commented on the issue:

    https://github.com/apache/nifi/pull/2936
  
    @mosermw Port added sir. :)


---

[GitHub] nifi issue #2936: NIFI-5489: Add expression language support to AMQP process...

Posted by alopresto <gi...@git.apache.org>.

Github user alopresto commented on the issue:

    https://github.com/apache/nifi/pull/2936
  
    @danieljimenez correct, PRs merged now will be included in the next release. Because our *bug fix* releases (`x.x.1`) do not include feature work, this will be in the next *minor* release, which is `1.8.0`. 


---

[GitHub] nifi issue #2936: NIFI-5489: Add expression language support to AMQP process...

Posted by mosermw <gi...@git.apache.org>.

Github user mosermw commented on the issue:

    https://github.com/apache/nifi/pull/2936
  
    Please do add Port to your PR, if you can, then I think this will also cover NIFI-4723.  It looks like PORT_VALIDATOR already supports expression language, so you are good there.


---

[GitHub] nifi issue #2936: NIFI-5489: Add expression language support to AMQP process...

Posted by danieljimenez <gi...@git.apache.org>.

Github user danieljimenez commented on the issue:

    https://github.com/apache/nifi/pull/2936
  
    FWIW I am currently using a SNAPSHOT from 01782bf on a real RabbitMQ server.


---

[GitHub] nifi issue #2936: NIFI-5489: Add expression language support to AMQP process...

Posted by danieljimenez <gi...@git.apache.org>.

Github user danieljimenez commented on the issue:

    https://github.com/apache/nifi/pull/2936
  
    @mosermw I can, I just enabled the fields most likely to be variables for most use cases. If you'd like me to add that to this PR, I certainly can.


---